<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123726/">https://git.reviewboard.kde.org/r/123726/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/123726/diff/3/?file=411084#file411084line72" style="color: black; font-weight: bold; text-decoration: underline;">tests/ECMPoQmToolsTest/tr_thread_test.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">72</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QTimer</span> <span class="n">thread_start_timer</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">use QTimer::singleShot or QMetaObject::invokeMethod(Qt::QueueConnection).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">IMHO, everything in this test doesn't need QTimer, QMetaObject::invokeMethod is enough.</p></pre>
</div>
</div>
<br />
<p>- Xuetian Weng</p>
<br />
<p>On October 14th, 2015, 8:49 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Extra Cmake Modules, Aurélien Gâteau and Chusslove Illich.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Oct. 14, 2015, 8:49 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=346188">346188</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">BUG: 346188</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Added tests for basic functionality and for loading a module on a thread. Both pass.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>modules/ECMPoQmTools.cmake <span style="color: grey">(12bcf6b67c57dd456f078820f86c1e8365cb7c06)</span></li>
<li>tests/ECMPoQmToolsTest/tr_thread_test_module.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMPoQmToolsTest/tr_thread_test.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMPoQmToolsTest/tr_test.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMPoQmToolsTest/tr_test-po/en_GB/catalog.po <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMPoQmToolsTest/tr_test-po/en/catalog.po <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMPoQmToolsTest/check_tree.cmake.in <span style="color: grey">(9f4f7c0d19f286647ad1c9c99362bd921ff01cba)</span></li>
<li>tests/ECMPoQmToolsTest/check_conf.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMPoQmToolsTest/CMakeLists.txt <span style="color: grey">(15351d2f710f9bd07a38d3b1ad9b15e24bc64a61)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(8a75ae61d9c2ce2eeb78e0a4c308d0d0c5fff5a5)</span></li>
<li>modules/ECMQmLoader.cpp.in <span style="color: grey">(bc01bf98f0caa0aedf6b6175ef6c9f7757afdf1b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123726/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>