<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125375/">https://git.reviewboard.kde.org/r/125375/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This file doesn't behave at all like find modules usually do. Instead of generating a config file, it should use components, and it shouldn't provide a version macro, but should parse out the version itself. It should be much more in the style of FindWayland.cmake.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In short, this module needs rewriting from scratch. Also, if there is only one project that needs it, I would suggest just shipping it directly in that project. ECM follows the "two or more users" rule in general - there needs to be two or more downstream users to justify shipping it in ECM.</p></pre>
<br />
<p>- Alex Merry</p>
<br />
<p>On September 24th, 2015, 3:21 p.m. UTC, Boudhayan Gupta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Build System and Alex Merry.</div>
<div>By Boudhayan Gupta.</div>
<p style="color: grey;"><i>Updated Sept. 24, 2015, 3:21 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Move FindAlsa from attic to find-modules. libKCompactDisc would like to use it.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">EDIT: For some reason git diff generates an empty file after I git add the files, but here's the git status output:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">$: git status
On branch master
Your branch is up-to-date with 'origin/master'.
Changes to be committed:
(use "git reset HEAD <file>..." to unstage)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"> renamed: attic/modules/FindAlsa.cmake -> find-modules/FindAlsa.cmake
renamed: attic/modules/config-alsa.h.cmake -> find-modules/config-alsa.h.cmake
</pre></div>
</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>attic/modules/FindAlsa.cmake <span style="color: grey">(1bad812)</span></li>
<li>attic/modules/config-alsa.h.cmake <span style="color: grey">(fb9cb8c)</span></li>
<li>find-modules/FindAlsa.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>find-modules/config-alsa.h.cmake <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125375/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>