<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124613/">https://git.reviewboard.kde.org/r/124613/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124613/diff/1/?file=389799#file389799line73" style="color: black; font-weight: bold; text-decoration: underline;">modules/ksb/BuildSystem.pm</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">sub module</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">73</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">(</span><span class="ow">not</span> <span class="o">-</span><span class="n">e</span> <span class="s">"$builddir/$confFileKey"</span><span class="p">));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">73</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="s">"the last configure failed"</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This file is only created by the user. This message belongs with "$confFileKey"'s condition below.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The message here should be "the build directory was manually marked out-of-date" or something to that effect.</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124613/diff/1/?file=389799#file389799line79" style="color: black; font-weight: bold; text-decoration: underline;">modules/ksb/BuildSystem.pm</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">sub module</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">79</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="s">"the failure-count is "</span> <span class="o">.</span> <span class="nv">$module</span><span class="o">-></span><span class="n">getPersistentOption</span><span class="p">(</span><span class="s">'failure-count'</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Would recommend a message like '$count previous attempts to build this module have failed' (or even just remove the count).</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124613/diff/1/?file=389799#file389799line82" style="color: black; font-weight: bold; text-decoration: underline;">modules/ksb/BuildSystem.pm</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">sub module</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">82</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="s">"$builddir/$confFileKey is missing"</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">this</em> is the one that should be "the last configure failed". ;)</p></pre>
</div>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">One other thing, the "l10nSystem" class is a source updater and a build system combined, and has a 'needsRefreshed' sub that would also need updated. Something like this diff should work:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span style="color: #000080; font-weight: bold">diff --git a/modules/ksb/l10nSystem.pm b/modules/ksb/l10nSystem.pm</span>
<span style="color: #000080; font-weight: bold">index e5756f8..0101824 100644</span>
<span style="color: #A00000">--- a/modules/ksb/l10nSystem.pm</span>
<span style="color: #00A000">+++ b/modules/ksb/l10nSystem.pm</span>
<span style="color: #800080; font-weight: bold">@@ -24,7 +24,9 @@ sub new</span>
# TODO: Support different localization branches?
$module->setOption('module-base-path', 'trunk/l10n-kde4');
<span style="color: #A00000">- return bless { module => $module, needsRefreshed => 1 }, $class;</span>
<span style="color: #00A000">+</span>
<span style="color: #00A000">+ my $refreshMessage = "couldn't verify the source is unchanged";</span>
<span style="color: #00A000">+ return bless { module => $module, needsRefreshed => $refreshMessage }, $class;</span>
}
sub module
<span style="color: #800080; font-weight: bold">@@ -75,7 +77,7 @@ sub updateInternal</span>
$self->check_module_validity();
my $count = $self->update_module_path(@dirs);
<span style="color: #A00000">- $self->{needsRefreshed} = 0 if $count == 0;</span>
<span style="color: #00A000">+ $self->{needsRefreshed} = '' if $count == 0;</span>
return $count;
}
else {
<span style="color: #800080; font-weight: bold">@@ -103,7 +105,7 @@ sub needsRefreshed</span>
{
my $self = shift;
<span style="color: #A00000">- # Should be 1 except if no update happened.</span>
<span style="color: #00A000">+ # Should be a 'reason' string except if no update happened.</span>
return $self->{needsRefreshed};
}
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">With those taken care of you have a +1 from me.</p></pre>
<p>- Michael Pyne</p>
<br />
<p>On August 4th, 2015, 9:57 a.m. UTC, David Faure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Build System and Michael Pyne.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated Aug. 4, 2015, 9:57 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdesrc-build
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i.e. be more precise than "meets other building criteria"</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Example:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">$ kdesrc-build --refresh plasma-nm</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Building plasma-nm from kf5-network-management (1/1)
Updating plasma-nm (to branch master)
No source update, but the option refresh-build was set
Source update complete for plasma-nm: no files affected
Preparing build system for plasma-nm.
...</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>modules/ksb/BuildSystem.pm <span style="color: grey">(24963040d77dc93f8f86a2f19755c617713bbd8a)</span></li>
<li>modules/ksb/IPC.pm <span style="color: grey">(0e55c5fe5c2a8771f6b9b159a684bdcc6dda52a7)</span></li>
<li>modules/ksb/Module.pm <span style="color: grey">(a7a7fbcc5e30cbb4c52979d87407a3250b80f2b2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124613/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>