<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123722/">https://git.reviewboard.kde.org/r/123722/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Extra Cmake Modules.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated May 13, 2015, 6:22 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit 1b636b43d2bf4dca0332a2e2b36affa67fbe1e0b by Alex Merry to branch master.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=345797">345797</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add PROPERTIES argument to ecm_add_test and ecm_add_tests.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is particularly useful with ecm_add_tests, where you may want to
force a suite of tests to run in serial, or alter the timeout for
multiple tests at once.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">BUG: 345797</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add unit tests for ECMAddTests module.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Newly-created unit tests pass.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>modules/ECMAddTests.cmake <span style="color: grey">(de06315d589eb8954cc18810f5dff922161fcfec)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(bc3e5ce8157cdbcc7d4285344898afd948432de3)</span></li>
<li>tests/ECMAddTests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMAddTests/check_files.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMAddTests/multi_tests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMAddTests/multi_tests/test1.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMAddTests/multi_tests/test10.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMAddTests/multi_tests/test11.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMAddTests/multi_tests/test2.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMAddTests/multi_tests/test3.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMAddTests/multi_tests/test4.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMAddTests/multi_tests/test5.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMAddTests/multi_tests/test6.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMAddTests/multi_tests/test7.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMAddTests/multi_tests/test8.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMAddTests/multi_tests/test9.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMAddTests/single_tests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMAddTests/single_tests/test1.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMAddTests/single_tests/test2.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMAddTests/single_tests/test3.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMAddTests/single_tests/test4.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMAddTests/single_tests/test5.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMAddTests/single_tests/test6.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMAddTests/single_tests/test6body.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMAddTests/single_tests/test7.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMAddTests/testhelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMAddTests/testhelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123722/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>