<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122193/">https://git.reviewboard.kde.org/r/122193/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Januar 29th, 2015, 11:15 nachm. UTC, <b>Friedrich W. H. Kossebau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Aha, am not the only one with a patch about "Various projects use various naming conventions, so supporting only lowercase.h headers in ECMGenerateHeaders is a bit limiting" :)
Just that my case are CamelCase.h headers, see https://git.reviewboard.kde.org/r/122317/
No idea yet how these two patches could be aligned, but ideally they would. Will think about some more next week.</p></pre>
</blockquote>
<p>On Februar 3rd, 2015, 12:41 nachm. UTC, <b>Daniel Vrátil</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I think we might extend your patch so that in addition to LOWERCASE and CAMELCASE it also supports something like LOWERCASE_SEPARATOR and CAMELCASE_SEPARATOR, and addiong ORIGINAL_SEPARATOR option to specify whether dash or underscore is used? This would probably cover most cases that make sense.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I can look into extending your patch and send you a mail, alternatively we could just merge yours (if Alex is OK with it), and will rebase this patch on top of your new changes.</p></pre>
</blockquote>
<p>On Februar 3rd, 2015, 8:12 nachm. UTC, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I think explicit arguments like in Friedrich's patch are the way to go. If you're willing to sort out a patch combining both features, I don't mind where it ends up, though.</p></pre>
</blockquote>
<p>On Februar 5th, 2015, 6:48 vorm. UTC, <b>Friedrich W. H. Kossebau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Of course I would not mind simply already committing my patch, that way my issues are already scratched ;) and I know the next release will cover it, independing if further discussions will hold up this patch here. Just, as I learned by this patch, unit tests are possible also with ecm, so I should add one.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">WRT to explicit arguments, being strict about only filenames with separators or not, I wonder if separators are used consistently with filenames. One real-word example from KDE repos: include/KF5/konq_historyentry.h for class KonqHistoryEntry. So some people use separators only randomly, so not to separate any words, but just a few. So it might make sense to extend this patch to only optionally expect separators (hm, perhaps by using <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">file(GLOB)</code> to get a list of all candidates, and if no=1 take that, otherwise complain), unless we are okay with enforcing people to rename their original header files to match exactly the pattern expected.</p></pre>
</blockquote>
<p>On Februar 6th, 2015, 11:41 vorm. UTC, <b>Daniel Vrátil</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'll just rebase my patch on yours once it's pushed, I'm not in hurry to get my changes in :)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I think there's a limit to how "clever" this utility should be - handling all possible and impossible naming conventions is probably not worth the added complexity - it will at least force the devs to fix their naming conventions ;-)</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">122317 is committed now, so you can rebase and improve :)</pre>
<br />
<p>- Friedrich W. H.</p>
<br />
<p>On Januar 21st, 2015, 9:25 nachm. UTC, Daniel Vrátil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Build System.</div>
<div>By Daniel Vrátil.</div>
<p style="color: grey;"><i>Updated Jan. 21, 2015, 9:25 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Various projects use various naming conventions, so supporting only lowercase.h headers in ECMGenerateHeaders is a bit limiting :) This patch adds a fallback which will try to look for lower-case.h header file in case lowercase.h does not exist.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Added a unit-test which seems to pass.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>modules/ECMGenerateHeaders.cmake <span style="color: grey">(bac5086)</span></li>
<li>tests/ECMGenerateHeadersTest/run_test.cmake.config <span style="color: grey">(0a2425f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122193/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>