<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121696/">https://git.reviewboard.kde.org/r/121696/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Works like a charm. Thanks for making this happen :)</p></pre>
<br />
<p>- Harald Sitter</p>
<br />
<p>On December 27th, 2014, 3:33 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Extra Cmake Modules and Harald Sitter.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Dec. 27, 2014, 3:33 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Lots of libraries will want to use SameMajorVersion to make sure
searching for version 1 of a library doesn't give you version 2, for
example.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We may want to add another, custom compatibility mode for
KDE Frameworks-style versioning, where version x.90.z to x.99.z are
alpha/beta releases for version (x+1).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See unit tests - all pass.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>modules/ECMSetupVersion.cmake <span style="color: grey">(2aff0ae0dee4fbd511b6fed76e9ca778aab9c545)</span></li>
<li>tests/ECMSetupVersionTest/CMakeLists.txt <span style="color: grey">(2e7decfb897c9447433038cbcb5800a09779eb24)</span></li>
<li>tests/ECMSetupVersionTest/old_version_file_anynewer/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/old_version_file_anynewer/main.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/old_version_file_exact/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/old_version_file_exact/main.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/old_version_file_samemajor/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/old_version_file_samemajor/main.c <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121696/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>