<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121646/">https://git.reviewboard.kde.org/r/121646/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Extra Cmake Modules and Stephen Kelly.</div>
<div>By Alex Merry.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Creating variables whose names start with CMAKE_ is a bad idea for
modules distributed outside CMake itself. Since the module is called
KDEInstallDirs, having a KDE_INSTALL_ prefix for the variables is clear
and intuitive.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Both CMAKE_INSTALL_* variables and the older KDELibs4-compatible
variables are provided, unless KDE_INSTALL_DIRS_NO_DEPRECATED is set to
TRUE before the module is included. Even then, the CMAKE_INSTALL_*
variables provided by the GNUInstallDirs module will still be set and
understood (for compatibility with that module), unless
KDE_INSTALL_DIRS_NO_CMAKE_VARIABLES is set to TRUE.</p>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Refactor KDEInstallDirs tests.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">make test</code> passes. I will do a rebuild of frameworks soon.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tests/KDEInstallDirsTest/qt_vars_defined/CMakeLists.txt <span style="color: grey">(910a0ede23e71a2562a8b75d40fa84dc4e31d2a1)</span></li>
<li>tests/KDEInstallDirsTest/usr_vars_defined/CMakeLists.txt <span style="color: grey">(aea07604c3c6d11e4ed09922dca528469717809c)</span></li>
<li>tests/KDEInstallDirsTest/usr_vars_defined/main.c <span style="color: grey">()</span></li>
<li>tests/KDEInstallDirsTest/var_list.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/KDEInstallDirsTest/vars_defined/CMakeLists.txt <span style="color: grey">(ab46cee112dd95a72b2ff90c26d8415631602e1c)</span></li>
<li>tests/KDEInstallDirsTest/vars_defined/main.c <span style="color: grey">()</span></li>
<li>tests/KDEInstallDirsTest/vars_in_sync/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/test_helpers.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>kde-modules/KDEInstallDirs.cmake <span style="color: grey">(46d3a5c69bf9b3bc548dd600484298cdf59a9fdf)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(0ee544a55708991c48470299965eacba814e7452)</span></li>
<li>tests/KDEInstallDirsTest/not_cache_variable/CMakeLists.txt <span style="color: grey">(ea62d95bea07f77917f2269b8b89d665a7f36ba5)</span></li>
<li>tests/KDEInstallDirsTest/qt_vars_defined/main.c <span style="color: grey">(c13815cea825c1f1ea72190a7fe901cd1fa55d0d)</span></li>
<li>tests/KDEInstallDirsTest/relative_or_absolute/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121646/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>