<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119630/">https://git.reviewboard.kde.org/r/119630/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Akonadi and Build System.</div>
<div>By Vadim Zhukov.</div>
<p style="color: grey;"><i>Updated Aug. 6, 2014, 3:23 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
akonadi
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Akonadi uses backtrace() facility, which could be defined in different headers and actually live in different libraries, depending on OS. The CMake distribution has FindBacktrace.cmake module as of 3.0.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In case it's not desirable to depend on CMake 3.x, and given that CMake modules are released under BSD-style license, the FindBacktrace.cmake from CMake distribution could be used. This CMake module could be downloaded here: https://github.com/Kitware/CMake/raw/master/Modules/FindBacktrace.cmake</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch removes more lines than adds, so it can't be bad. ;) And it fixes official Akonadi package build on OpenBSD.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Please note that I don't have commit access to KDE repos. Thus, if this patch will get accepted, it should be committed by someone else. Thanks.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Akonadi 1.12.1 and "master" ones, OpenBSD/i386 5.6-BETA, KDE 4.13.3</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(5bbe59f)</span></li>
<li>cmake/modules/FindBacktrace.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>config-akonadi.h.cmake <span style="color: grey">(5e4c4b9)</span></li>
<li>server/tests/unittest/imapstreamparsertest.cpp <span style="color: grey">(738147b)</span></li>
<li>shared/akcrash.cpp <span style="color: grey">(87662fb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119630/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>