<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117617/">https://git.reviewboard.kde.org/r/117617/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 50b164a7ce83cdaec18209c7c2226d2fdb9cf29e by Alex Merry to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On April 17th, 2014, 7:40 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Build System, Extra Cmake Modules and KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated April 17, 2014, 7:40 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Apologies for the slightly ridiculous changeset. The unit tests involve lots of (mostly identical) files.
New syntax for ecm_install_icons()
This requires the icon files to be specified (which is better than
globbing, because the build system will then be able to tell when files
are added or removed and re-run CMake).
It also removes the theme name from the filename pattern: the old code
used a shorthand theme name for a small number of themes, and didn't
allow any other themes. Extending this to arbitrary themes could cause
problems with themes that have numbers or hyphens (or whatever other
delimiter character was used) in their names. Most users are likely to
just want to install to a single theme anyway (based on a random
sampling of users of kde4_install_icons), so that is what the new syntax
requires.
The old syntax still works and behaves as before.
ecm_update_iconcache is renamed to _ecm_update_iconcache - it was never
documented as public API anyway.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tests (included as part of commit) pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>modules/ECMInstallIcons.cmake <span style="color: grey">(d83003bac633d14ec538af539c3b414992c5f8e4)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(e464a0305bd71364463c3132103ffe02dcb94eb6)</span></li>
<li>tests/ECMInstallIconsTest/128-devices-drive-removable-media-usb-pendrive.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/128-emblems-emblem-mounted.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/128-places-home.mng <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/16-actions-badext.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/16-actions-computer.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/16-animations-loading.mng <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/16-apps-cmake.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/16-categories-system-help.mng <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/16-emotes-face-smile.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/16-intl-something.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/16-status-user-online.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/aa-actions-badsize.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/badlynamedfile.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/check_tree.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/badly-named-files-test/hicolor/16x16/actions/badext.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/lang-test/hicolor/128x128/devices/l10n/en_US/drive-removable-media-usb-pendrive.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/lang-test/hicolor/128x128/emblems/l10n/en_US/emblem-mounted.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/lang-test/hicolor/128x128/places/l10n/en_US/home.mng <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/lang-test/hicolor/16x16/actions/l10n/en_US/computer.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/lang-test/hicolor/16x16/animations/l10n/en_US/loading.mng <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/lang-test/hicolor/16x16/apps/l10n/en_US/cmake.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/lang-test/hicolor/16x16/categories/l10n/en_US/system-help.mng <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/lang-test/hicolor/16x16/emotes/l10n/en_US/face-smile.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/lang-test/hicolor/16x16/intl/l10n/en_US/something.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/lang-test/hicolor/16x16/status/l10n/en_US/user-online.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/lang-test/hicolor/scalable/mimetypes/l10n/en_US/fonts-package.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/multi-file-test/hicolor/128x128/devices/drive-removable-media-usb-pendrive.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/multi-file-test/hicolor/128x128/emblems/emblem-mounted.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/multi-file-test/hicolor/128x128/places/home.mng <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/multi-file-test/hicolor/16x16/actions/computer.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/multi-file-test/hicolor/16x16/animations/loading.mng <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/multi-file-test/hicolor/16x16/apps/cmake.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/multi-file-test/hicolor/16x16/categories/system-help.mng <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/multi-file-test/hicolor/16x16/emotes/face-smile.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/multi-file-test/hicolor/16x16/intl/something.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/multi-file-test/hicolor/16x16/status/user-online.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/multi-file-test/hicolor/scalable/mimetypes/fonts-package.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/single-file-test/hicolor/16x16/actions/computer.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/themed-lang-test/oxygen/128x128/devices/l10n/en_US/drive-removable-media-usb-pendrive.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/themed-lang-test/oxygen/128x128/emblems/l10n/en_US/emblem-mounted.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/themed-lang-test/oxygen/128x128/places/l10n/en_US/home.mng <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/themed-lang-test/oxygen/16x16/actions/l10n/en_US/computer.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/themed-lang-test/oxygen/16x16/animations/l10n/en_US/loading.mng <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/themed-lang-test/oxygen/16x16/apps/l10n/en_US/cmake.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/themed-lang-test/oxygen/16x16/categories/l10n/en_US/system-help.mng <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/themed-lang-test/oxygen/16x16/emotes/l10n/en_US/face-smile.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/themed-lang-test/oxygen/16x16/intl/l10n/en_US/something.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/themed-lang-test/oxygen/16x16/status/l10n/en_US/user-online.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/themed-lang-test/oxygen/scalable/mimetypes/l10n/en_US/fonts-package.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/themed-test/theme-name-2/128x128/devices/drive-removable-media-usb-pendrive.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/themed-test/theme-name-2/128x128/emblems/emblem-mounted.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/themed-test/theme-name-2/128x128/places/home.mng <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/themed-test/theme-name-2/16x16/actions/computer.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/themed-test/theme-name-2/16x16/animations/loading.mng <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/themed-test/theme-name-2/16x16/apps/cmake.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/themed-test/theme-name-2/16x16/categories/system-help.mng <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/themed-test/theme-name-2/16x16/emotes/face-smile.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/themed-test/theme-name-2/16x16/intl/something.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/themed-test/theme-name-2/16x16/status/user-online.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/themed-test/theme-name-2/scalable/mimetypes/fonts-package.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/v1-icons/crystalsvg/128x128/emblems/emblem-mounted.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/v1-icons/crystalsvg/128x128/emblems/l10n/en_US/emblem-mounted.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/v1-icons/hicolor/128x128/devices/drive-removable-media-usb-pendrive.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/v1-icons/hicolor/128x128/places/home.mng <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/v1-icons/hicolor/128x128/places/l10n/en_US/home.mng <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/v1-icons/hicolor/16x16/actions/computer.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/v1-icons/hicolor/16x16/actions/l10n/en_US/computer.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/v1-icons/hicolor/16x16/animations/loading.mng <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/v1-icons/hicolor/16x16/apps/cmake.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/v1-icons/hicolor/16x16/emotes/face-smile.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/v1-icons/hicolor/16x16/intl/something.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/v1-icons/hicolor/16x16/status/user-online.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/v1-icons/locolor/scalable/mimetypes/fonts-package.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/v1-icons/locolor/scalable/mimetypes/l10n/en_US/fonts-package.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/v1-icons/oxygen/16x16/categories/l10n/en_US/system-help.mng <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/expected-tree/v1-icons/oxygen/16x16/categories/system-help.mng <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/sc-mimetypes-fonts-package.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/v1-syntax-l10n/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/v1-syntax-l10n/cr128-emblems-emblem-mounted.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/v1-syntax-l10n/hi128-places-home.mng <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/v1-syntax-l10n/hi16-actions-computer.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/v1-syntax-l10n/losc-mimetypes-fonts-package.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/v1-syntax-l10n/ox16-categories-system-help.mng <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/v1-syntax/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/v1-syntax/cr128-emblems-emblem-mounted.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/v1-syntax/hi128-devices-drive-removable-media-usb-pendrive.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/v1-syntax/hi128-places-home.mng <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/v1-syntax/hi16-actions-computer.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/v1-syntax/hi16-animations-loading.mng <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/v1-syntax/hi16-apps-cmake.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/v1-syntax/hi16-emotes-face-smile.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/v1-syntax/hi16-intl-something.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/v1-syntax/hi16-status-user-online.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/v1-syntax/losc-mimetypes-fonts-package.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMInstallIconsTest/v1-syntax/ox16-categories-system-help.mng <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117617/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>