<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117619/">https://git.reviewboard.kde.org/r/117619/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thank you so much. This was supposed to be on my todo list, but I had forgotten about it. And you did it much better than I would ever have done, with cmake-based unittests and all :-)
+1 from me, giving a chance to Alex Neundorf to review it in more details.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/117619/diff/1/?file=266693#file266693line27" style="color: black; font-weight: bold; text-decoration: underline;">modules/ECMSetupVersion.cmake</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">27</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c"># <prefix>_VERSION_STRING - <version> (for compatibility, use <prefix>_VERSION)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The sentence is ambiguous. It could mean "_VERSION_STRING is for compat, use _VERSION instead", or it could mean "_VERSION_STRING is newer, but if you want your code to be more compatible, use _VERSION".
>From the diff I assume the first one was meant, so append "instead" and turn the ',' into ';', maybe?
</pre>
</div>
<br />
<p>- David Faure</p>
<br />
<p>On April 17th, 2014, 9:13 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Build System, Extra Cmake Modules and KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated April 17, 2014, 9:13 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Make ecm_setup_version interact well with CMP0048
When CMake policy CMP0048 (CMake 3.0) is set to NEW, the project()
command is meant to manage the project's version variables. We therefore
do not set the PROJECT_VERSION variables in this case.
To make sure projects do not have to specify their version in multiple
places, this also allows the keyword "PROJECT" to be passed to
ecm_setup_version instead of an actual version number. In this case, the
version passed to project() will be used.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Bundled autotests pass. Freshly configured, built and installed KArchive - version header file and KF5ArchiveConfigVersion.cmake correct by inspection. KEmoticons then configured successfully (finding KF5Archive >= 4.96.0).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>modules/ECMSetupVersion.cmake <span style="color: grey">(3ae6fa8f73357f5958de9f54adf083bf6de03df0)</span></li>
<li>modules/ECMVersionHeader.h.in <span style="color: grey">(19eb96c53d3b518df6b364e249707f12892b6893)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(e464a0305bd71364463c3132103ffe02dcb94eb6)</span></li>
<li>tests/ECMSetupVersionTest/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/new_explicit_header/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/new_explicit_header/main.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/new_explicit_header_abspath/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/new_explicit_header_abspath/main.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/new_explicit_simple/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/new_explicit_simple/main.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/new_explicit_soversion/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/new_explicit_soversion/main.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/new_explicit_version_file/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/new_explicit_version_file/main.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/new_explicit_version_file_abspath/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/new_explicit_version_file_abspath/main.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/new_project_header/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/new_project_header/main.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/new_project_header_abspath/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/new_project_header_abspath/main.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/new_project_header_prefix/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/new_project_header_prefix/main.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/new_project_simple/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/new_project_simple/main.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/new_project_simple_prefix/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/new_project_simple_prefix/main.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/new_project_soversion/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/new_project_soversion/main.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/new_project_soversion_prefix/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/new_project_soversion_prefix/main.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/new_project_version_file/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/new_project_version_file/main.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/new_project_version_file_abspath/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/new_project_version_file_abspath/main.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/old_header/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/old_header/main.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/old_header_abspath/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/old_header_abspath/main.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/old_simple/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/old_simple/main.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/old_soversion/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/old_soversion/main.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/old_version_file/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/old_version_file/main.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/old_version_file_abspath/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ECMSetupVersionTest/old_version_file_abspath/main.c <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117619/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>