<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117658/">https://git.reviewboard.kde.org/r/117658/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Build System, Extra Cmake Modules and KDE Frameworks.</div>
<div>By Alex Merry.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Split up module execution tests
Find module tests now use find_package(), and there is a version for
when CMAKE_MODULE_PATH is set and a version for when
ecm_use_find_modules() is used.
KDE modules are also now tested.
Add a stub for ECMFindModuleHelpers to the find-modules dir
ECMUseFindModules allows find modules to be copied to a local directory.
These find modules may use ECMFindModuleHelpers, but they will not be in
the same relative location to ECMFindModuleHelpers.cmake and there is no
guarantee that ECMFindModulesHelpers.cmake will be in the CMake module
path.
To solve this, we make sure there is always a stub file in the same
directory as the find modules that includes the real
ECMFindModuleHelpers.cmake. The one installed with ECM just includes
"../modules/ECMFindModuleHelpers.cmake", while ecm_use_find_modules
generates a stub that uses an absolute path.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tests pass. Also made a little test that called find_package(Wayland), both using set(CMAKE_MODULE_PATH ${ECM_FIND_MODULE_DIR}) and using ecm_use_find_modules(), and Wayland was found both times.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>find-modules/FindWayland.cmake <span style="color: grey">(b7790e750e8ae9b1c6d5be81b7683b489d60a5a7)</span></li>
<li>find-modules/ECMFindModuleHelpersStub.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>find-modules/FindXCB.cmake <span style="color: grey">(dd876b214edd35993b8e8d3582536a24776a2e64)</span></li>
<li>modules/ECMUseFindModules.cmake <span style="color: grey">(25f42666ceaecdac4034caf43c31f3f219f9070b)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(e464a0305bd71364463c3132103ffe02dcb94eb6)</span></li>
<li>tests/ExecuteAllModules/CMakeLists.txt <span style="color: grey">(12e86c15d209ff38340af0dd0a5900091ce4cadb)</span></li>
<li>tests/ExecuteAllModules/main.c <span style="color: grey">()</span></li>
<li>tests/ExecuteCoreModules/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ExecuteKDEModules/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/ExecuteKDEModules/main.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/FindModules/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/FindModules/main.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/UseFindModules/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/UseFindModules/main.c <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117658/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>