<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115876/">https://git.reviewboard.kde.org/r/115876/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 21st, 2014, 7:47 p.m. UTC, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The files have been moved to kdoctools, should I open a new review against the kdoctools component or can I get a shipit here? :)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I thought I'd already made this reply, but let's try again... (maybe I did it on another RR?)
I would rather this was combined with https://git.reviewboard.kde.org/r/115879/ as a single commit/review in kdoctools.</pre>
<br />
<p>- Alex</p>
<br />
<p>On February 18th, 2014, 10:52 p.m. UTC, Luigi Toscano wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Build System, Documentation and KDE Frameworks.</div>
<div>By Luigi Toscano.</div>
<p style="color: grey;"><i>Updated Feb. 18, 2014, 10:52 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">FindDocBookXML.cmake was originally part of kdelibs/kdoctools, but not installed. The version currently in ECM is, as the old one, is quite tight to the old behavior, it hardcodes the DocBookXML version currently used.
- the rename reflect the fact that it's used for DocBookXML4; a future DocBookXML5 could be added if needed;
- the structure allows a generic usage ("find DocBookXML version 4.x"), not tied to the usage in KDocTools. KDocTools will be changed to call it with the correct version (the version number is a "property" of KDocTools, not used outside it, but hidden inside meinproc5 and libKF5XsltKde.a).
Next changes:
- use DocBookXML4 (so DocBookXML4_* instead of DOCBOOKXML_* legacy variables) in frameworks
- move the definition of legacy DOCBOOKXML_* in kde4support
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles (some changes are needed in KDocTools, I will add them to another review).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>find-modules/FindDocBookXML.cmake <span style="color: grey">(b6d623e)</span></li>
<li>find-modules/FindDocBookXML4.cmake <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115876/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>