<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115632/">https://git.reviewboard.kde.org/r/115632/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 12th, 2014, 2:52 a.m. UTC, <b>Michael Pyne</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115632/diff/1/?file=243097#file243097line23" style="color: black; font-weight: bold; text-decoration: underline;">kf5-applications-build-include</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">23</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">module kdevplatform</pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Would be better for these 2 modules to be a 'kde-projects'-based module-set.
This allows kdesrc-build to automatically select the right branch (per the branch-group setting) if the kde-build-metadata is up to date (which seems to be the case now).
Additionally it allows kdesrc-build to use dependency data in kde-build-metadata to ensure the right build order.
Would look something like:
module-set
repository kde-projects
use-modules kdevplatform kdevelop/kdevelop
end module-set
The "kdevelop/kdevelop" is just to disambiguate, otherwise kdesrc-build would pull in "kdevelop/*" for everything not ignored in kde-build-metadata/build-script-ignore.
What is here is fine too, but if the appropriate branch for kdevelop ever changes that could lead to problems later, which is why I'm trying to push back toward branch-groups.</pre>
</blockquote>
<p>On February 12th, 2014, 9:46 a.m. UTC, <b>Kevin Funk</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hm. So, where should I put the following lines then?
module-set
repository kde-projects
use-modules kdevplatform kdevelop/kdevelop
end module-set
This is no longer depending on 'frameworks' or anything. So is it suited to be put into kdesrc-buildrc-setup or something? At least that's the place where I see lots of 'module-set'-based constructs.
It's also fine if you just commit whatever you think fits best here, given that I basically have no clue about kdesrc-build. All I wanted to do is to be able to 'kdesrc-build kdevelop' under KF5 :)</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry, I could have been more clear.
The theory is that in the "global" section of the main kdesrc-buildrc you have a setting called "branch-group kf5-qt5", as mentioned in the top-level comment of this configuration file. This tells kdesrc-build automagically which branch to pull (in this case, "frameworks").
In the future when the right branch to use for kdevelop becomes something else (presumably "master") then we the developers have to change one file in kde-build-metadata and then all kdesrc-build users using the branch-group setting will switch to the right branch on their next update.
If you have that branch-group setting in *your* .kdesrc-buildrc's global setting then doing "kdesrc-build kdevelop" might already work even without a specific configuration file command. :)
I'll go ahead and add it in at some point today.</pre>
<br />
<p>- Michael</p>
<br />
<p>On February 10th, 2014, 5:09 p.m. UTC, Kevin Funk wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Build System.</div>
<div>By Kevin Funk.</div>
<p style="color: grey;"><i>Updated Feb. 10, 2014, 5:09 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdesrc-build
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Two commits:
Add .reviewboardrc
Add frameworks-based kdevplatform + kdevelop</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>.reviewboardrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>kf5-applications-build-include <span style="color: grey">(dab8498dfd5a5f6dd7a63d8d06d1701770760b33)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115632/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>