<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114904/">https://git.reviewboard.kde.org/r/114904/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 7th, 2014, 9:43 p.m. UTC, <b>Alexander Neundorf</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The motivation was that if somebody had set up carefully his install dirs for kdelibs, he simply wanted to point a following project to the same CMAKE_INSTALL_PREFIX, and have all the other install dirs automatically use the same locations as the installed kdelibs.
Somebody, or maybe several people, requested this back then, I don't remember right now where or who it was.
</pre>
</blockquote>
<p>On January 7th, 2014, 9:49 p.m. UTC, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK, thanks for the info. I reckon this doesn't make much sense any more, given we have multiple tier1 frameworks. About the best we could do is maybe follow Qt's layout, but I suspect that isn't worth it (if Qt even gives us all the necessary information).</pre>
</blockquote>
<p>On January 7th, 2014, 10:04 p.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It was probably me.
But many things changed since then :)
There is no kdelibs anymore, and kdesrc-build makes it easy to specify the same prefix for everything.
This leaves the case of compiling an app against system libs for Qt+KF5, but I think we should rather aim at making this work as easily as possible with a different prefix for the app, rather than forcing the installation of the app into the KF5 prefix (e.g. RPATH helps there, KDEDIRS is no more, so at most PATH and XDG_DATA_DIRS need to be set, and not even PATH if there's just one binary invoked by full path).
Ah, there was another case I think, kdelibs configured by the distro with lots of custom paths (e.g. prefix of /usr but /etc instead of /usr/share/config for the config dir, and so on... that was more coolo's stuff). I suppose we have to find a solution for such things, but I'm no expert in this area (e.g. what would be convenient for distros). In any case the current stuff for sure doesn't work anymore, so a new solution will have to be used instead, if needed.
+1 for removing the old magic.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Okie dokie, since I got a +1 and no objections, I'm gonna commit this.</pre>
<br />
<p>- Alex</p>
<br />
<p>On January 19th, 2014, 1:21 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Build System, Extra Cmake Modules and KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Jan. 19, 2014, 1:21 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove KDE4 magic from _SET_FANCY in KDEInstallDirs.cmake
This appears to be a hangover from the KDE4 days, which would adjust
certain paths to match the ones for kdelibs if you installed an
application to the same prefix as kdelibs. This was probably to make
KStandardDirs work properly in unusual setups.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">CMake runs fine on KCoreAddons (clean build dir), and only the install prefix variable I set on the command line (CMAKE_INSTALL_PREFIX) is in the cache.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kde-modules/KDEInstallDirs.cmake <span style="color: grey">(838a52384b7cbfc84c5bd02c2f40f027f36db169)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114904/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>