<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/113887/">http://git.reviewboard.kde.org/r/113887/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
 <br />









<p>- Stephen Kelly</p>


<br />
<p>On November 15th, 2013, 5:34 p.m. UTC, Aleix Pol Gonzalez wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Build System and KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>


<p style="color: grey;"><i>Updated Nov. 15, 2013, 5:34 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Prefix them with kauth_* instead, also remove assumptions from kde4_*.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nothing stopped building.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>tier4/kde4support/CreateKDELibsDependenciesFile.cmake <span style="color: grey">(55fb337)</span></li>

 <li>tier2/kauth/src/kauthhelpersupport.h <span style="color: grey">(a9d7a53)</span></li>

 <li>tier2/kauth/src/kauthactionreply.h <span style="color: grey">(a91e667)</span></li>

 <li>tier2/kauth/src/kauthaction.h <span style="color: grey">(07a5506)</span></li>

 <li>tier2/kauth/src/ConfigureChecks.cmake <span style="color: grey">(f00f2fe)</span></li>

 <li>tier2/kauth/src/CMakeLists.txt <span style="color: grey">(f61eee5)</span></li>

 <li>tier2/kauth/KAuthConfig.cmake.in <span style="color: grey">(dee448b)</span></li>

 <li>tier2/kauth/cmake/KAuthMacros.cmake <span style="color: grey">(d942d69)</span></li>

 <li>tier4/kde4support/cmake/modules/KDE4Macros.cmake <span style="color: grey">(6a63e5e)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/113887/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>