<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112969/">http://git.reviewboard.kde.org/r/112969/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 27th, 2013, 3:06 p.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good to me. I'm surprised by the fact that FindQt4 would accept Qt5, I thought there was a check in there to make it refuse Qt5. Maybe your cmake is from before that additional check?
>From cmake git:
commit 153242601e22d6f06e1f14dc55d70c2a42b2ec5f
Merge: 28490ec 2112341
Author: Brad King <brad.king@kitware.com>
Date: Tue Mar 12 13:47:08 2013 -0400
Merge topic 'findqt4-withqt5'
2112341 FindQt4: Do not use qmake from Qt5
This is only in cmake >= 2.8.11, though.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, I think my cmake was older at that time when I was trying to build the master branch. After finding the correct frameworks branch cmake needed an update. Didn't realise it can influence this.</pre>
<br />
<p>- Casian</p>
<br />
<p>On September 28th, 2013, 8:16 a.m. UTC, Casian Andrei wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Build System.</div>
<div>By Casian Andrei.</div>
<p style="color: grey;"><i>Updated Sept. 28, 2013, 8:16 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If there is a problem with finding the Qt includes, then
FindKDE4Internal tells the user that Qt is not compiled correctly, and
it is not straight forward to realise that it is a false alarm.
Introduce a simple check for compiling a barebone Qt application before
attempting to check for -fvisibility=hidden. This way, the error message
states that Qt has not been found correctly, preventing confusion.
Update: I should have checked out the frameworks branch, not master... I was under the impression that it was merged into master :( . But perhaps this patch is still useful for KDE/4.11.
The error came from FindQt4 not finding the "Qt" include, which is not present with Qt5. Makes sense.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When trying without these changes:
-------------
-- Found Qt-Version 5.1.1 (using /usr/bin/qmake)
-- Building kdelibs...
CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
QT_QT_INCLUDE_DIR
used as include directory in directory /usr/local/src/kdesrc/build/kdelibs/CMakeFiles/CMakeTmp
CMake Error: Internal CMake error, TryCompile configure of cmake failed
CMake Error at cmake/modules/FindKDE4Internal.cmake:1294 (message):
Qt compiled without support for -fvisibility=hidden. This will break
plugins and linking of some applications. Please fix your Qt installation
(try passing --reduce-exports to configure).
Call Stack (most recent call first):
CMakeLists.txt:56 (find_package)
--------------
Scary!
--------------
When trying after these changes:
-- Found Qt-Version 5.1.1 (using /usr/bin/qmake)
-- Building kdelibs...
CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
QT_QT_INCLUDE_DIR
used as include directory in directory /usr/local/src/kdesrc/build/kdelibs/CMakeFiles/CMakeTmp
CMake Error: Internal CMake error, TryCompile configure of cmake failed
CMake Error at cmake/modules/FindKDE4Internal.cmake:1308 (message):
Unable to compile a basic Qt application. Qt has not been found correctly.
Call Stack (most recent call first):
CMakeLists.txt:56 (find_package)
--------------
Less scary :-)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/FindKDE4Internal.cmake <span style="color: grey">(7922b09)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112969/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>