<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112697/">http://git.reviewboard.kde.org/r/112697/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 13th, 2013, 7:35 a.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">See the docu inside kdelibs-frameworks/superbuild/CMakeLists.txt.
This is preparation for future splitting. The variables are necessary for that, for now, as I understand it.
Let's finish moving everything into separate frameworks, then we can finally split up kdelibs and stop having to care for two ways to build stuff :)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, then it shouldn't matter, because it makes the modules less inter-dependent.
At the moment we're relying too much about things defined in kdelibs/CMakeLists.txt and we're having things defined in weird ways, IMHO.</pre>
<br />
<p>- Aleix</p>
<br />
<p>On September 13th, 2013, 10:33 a.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Build System, KDE Frameworks, Alexander Neundorf, and Stephen Kelly.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Sept. 13, 2013, 10:33 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">move add_subdirectory(tier2) right after add_subdirectory(tier1). Make it compile again.
It's good because this simplifies some doubts we've been having lately. Also it didn't do much down there, only right after setting the _LIBRARY variables.
In any case, everything in kdelibs/CMakeLists.txt under tier2 will have to go and move within each module, so it makes sense to start going in this direction.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Still builds.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(17f1b46)</span></li>
<li>tier2/kauth/autotests/CMakeLists.txt <span style="color: grey">(ff0feb0)</span></li>
<li>tier2/kauth/src/CMakeLists.txt <span style="color: grey">(31f0f9c)</span></li>
<li>tier2/kcrash/src/CMakeLists.txt <span style="color: grey">(f340acd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112697/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>