<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103701/">http://git.reviewboard.kde.org/r/103701/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You should include the target file only if the target does not already exist, something like
if(NOT TARGET Libkexiv2::kexiv2)
include(...cmake)
endif()
I would recommend not to disable the set_and_check() macro, and use it for the include dir instead of simply set().
set_and_check() will set the variable and check that the directory it points to actually exists.
This is good, because it ensures that the config.cmake file provides information which is actually consistent with the state in disk.
</pre>
<br />
<p>- Alexander</p>
<br />
<p>On May 5th, 2013, 8:02 p.m. UTC, Yury Kudryashov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Build System and Digikam.</div>
<div>By Yury Kudryashov.</div>
<p style="color: grey;"><i>Updated May 5, 2013, 8:02 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Now
find_package(libkexiv2 CONFIG)
finds LibKexiv2, removing need for large FindKexiv2.cmake script.
I've decided to install libkexiv2-config.cmake, not Kexiv2Config.cmake to avoid conflicts with FindKexiv2.cmake from kdelibs.
Also, I'm not sure about libkexiv2-config-version.cmake. I'm ready to adjust the default policy if someone will tell me about correct algorithm (SONAME? Same major version? Same major/minor? something else?).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">$ cmake .. -DCMAKE_INSTALL_PREFIX=$PWD/../install; cd ..;
$ cmake --find-package -DCMAKE_PREFIX_PATH=$PWD/../install -DNAME=libkexiv2 -DCOMPILER_ID=GNU -DLANGUAGE=CXX -DMODE=EXIST
$ cmake --find-package -DCMAKE_PREFIX_PATH=$PWD/../install -DNAME=libkexiv2 -DCOMPILER_ID=GNU -DLANGUAGE=CXX -DMODE=COMPILE
$ cmake --find-package -DCMAKE_PREFIX_PATH=$PWD/../install -DNAME=libkexiv2 -DCOMPILER_ID=GNU -DLANGUAGE=CXX -DMODE=LINK</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(8c89503ffb2de66be682af3b262756519db3af49)</span></li>
<li>libkexiv2-config.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>libkexiv2/CMakeLists.txt <span style="color: grey">(c706d820f54b412f45131a14276b13bfc07255a1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103701/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>