<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110319/">http://git.reviewboard.kde.org/r/110319/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Build System, Aleix Pol Gonzalez and Aaron J. Seigo.</div>
<div>By Harald Sitter.</div>
<p style="color: grey;"><i>Updated May 6, 2013, 1:24 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> replace finder script with cmake config making stuff scale
it would be cool if someone from kde-buildsystem could check that
everything is in order.
installing a finder yourself makes next to no sense considering cmake
configs do the same thing and do it better.
in particular the finder was installed into cmakedatadir/... which is not
searched by default (at least not by kde applications if kdedatadir !=
cmakedatadir, e.g. on debian /usr/share vs. /usr/share/kde4).
I retained the BODEGA naming but I think one should think about changing it
to Bodega as that looks rather a lot less silly.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">found by muon and muon's backend builds</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(97d1628c0af0ba3276699da20ce307ca22dde95f)</span></li>
<li>lib/CMakeLists.txt <span style="color: grey">(381c03f7e26adf95991bf020f214fbebd2060a6f)</span></li>
<li>lib/bodega/CMakeLists.txt <span style="color: grey">(1ecc498b494bdff8a75a3a4c49c61f4cdb66ccc4)</span></li>
<li>lib/cmake/BODEGAConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/cmake/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/cmake/modules/CMakeLists.txt <span style="color: grey">(0207620331bbf949018076ee526010443e6a3173)</span></li>
<li>lib/cmake/modules/FindBODEGA.cmake <span style="color: grey">(e4c69eec793ef4a7a9728241345c2d1cf9053fac)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110319/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>