<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108954/">http://git.reviewboard.kde.org/r/108954/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 14th, 2013, 6:12 p.m. UTC, <b>Alexander Neundorf</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As long as e-c-m is not released yet, there is still time for source incompatible changes.
But please list them here: http://techbase.kde.org/Development/ECM_SourceIncompatChanges
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We missed one point: FPHSA sets ${UPCASE_NAME}_FOUND, not ${NAME}_FOUND. BTW, are there any plans to change this (say, set both variables)?</pre>
<br />
<p>- Yury Georgievich</p>
<br />
<p>On February 14th, 2013, 9:44 a.m. UTC, Yury Georgievich Kudryashov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Build System.</div>
<div>By Yury Georgievich Kudryashov.</div>
<p style="color: grey;"><i>Updated Feb. 14, 2013, 9:44 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix FindLibUSB1
- set properties on LibUSB1, not USB1
- use LibUSB1_ prefix, not LIBUSB1_
Do we care about compatibility? If yes, we should set LIBUSB1_* variables as well.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>find-modules/FindLibUSB1.cmake <span style="color: grey">(100426ec606ff022526168d039dde65bccd808c1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108954/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>