<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103701/">http://git.reviewboard.kde.org/r/103701/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 8th, 2013, 11:26 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What's the state of this? Last activity is from 1 year. Do we still need this? Was it commited? There are improvements needed to be made?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch wasn't applied, e.g., because it didn't work with cmake 2.6.4. I'll test if it works with the current "minimum supported" cmake version, and update the patch next week.</pre>
<br />
<p>- Yury Georgievich</p>
<br />
<p>On January 17th, 2012, 11:58 p.m. UTC, Yury Georgievich Kudryashov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Build System and Digikam.</div>
<div>By Yury Georgievich Kudryashov.</div>
<p style="color: grey;"><i>Updated Jan. 17, 2012, 11:58 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Now
find_package(LibKexiv2 NO_MODULE)
finds LibKexiv2, removing need for large FindLibKexiv2.cmake script.
I've decided to install LibKexiv2Config.cmake, not Kexiv2Config.cmake to avoid conflicts with FindKexiv2.cmake from kdelibs.
P.S.: I think about moving large parts to a macro.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">$ cmake .. -DCMAKE_INSTALL_PREFIX=$PWD/../install; cd ..;
$ cmake --find-package -DCMAKE_PREFIX_PATH=$PWD/i -DNAME=LibKexiv2 -DCOMPILER_ID=GNU -DLANGUAGE=CXX -DMODE=EXIST
$ cmake --find-package -DCMAKE_PREFIX_PATH=$PWD/i -DNAME=LibKexiv2 -DCOMPILER_ID=GNU -DLANGUAGE=CXX -DMODE=COMPILE
$ cmake --find-package -DCMAKE_PREFIX_PATH=$PWD/i -DNAME=LibKexiv2 -DCOMPILER_ID=GNU -DLANGUAGE=CXX -DMODE=LINK</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(0ecd233)</span></li>
<li>LibKexiv2Config-external.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>LibKexiv2Config.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>LibKexiv2ConfigVersion.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>libkexiv2/CMakeLists.txt <span style="color: grey">(8a6b822)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103701/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>