<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108002/">http://git.reviewboard.kde.org/r/108002/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 92b4a1ee45064e3781c8c91c8fb34e74c2658432 by Christophe Giboudeaux to branch master.</pre>
 <br />







<p>- Commit</p>


<br />
<p>On December 29th, 2012, 1:47 p.m., Christophe Giboudeaux wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Build System, kdelibs and Alexander Neundorf.</div>
<div>By Christophe Giboudeaux.</div>


<p style="color: grey;"><i>Updated Dec. 29, 2012, 1:47 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch replaces all the macro_log_feature entries with feature_summary.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No issue detected. CMake detects the same dependencies as before.</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(0030b30)</span></li>

 <li>dnssd/CMakeLists.txt <span style="color: grey">(4a44acf)</span></li>

 <li>kdecore/CMakeLists.txt <span style="color: grey">(b147f22)</span></li>

 <li>kdecore/auth/ConfigureChecks.cmake <span style="color: grey">(ff17ff0)</span></li>

 <li>kdecore/compression/ConfigureChecks.cmake <span style="color: grey">(8edd173)</span></li>

 <li>kdeui/tests/proxymodeltestsuite/CMakeLists.txt <span style="color: grey">(0c9a129)</span></li>

 <li>kdewebkit/CMakeLists.txt <span style="color: grey">(21b2c5c)</span></li>

 <li>kdoctools/CMakeLists.txt <span style="color: grey">(26a9231)</span></li>

 <li>khtml/CMakeLists.txt <span style="color: grey">(99034cc)</span></li>

 <li>kimgio/CMakeLists.txt <span style="color: grey">(26329c0)</span></li>

 <li>kioslave/http/CMakeLists.txt <span style="color: grey">(95ed9cf)</span></li>

 <li>kjs/CMakeLists.txt <span style="color: grey">(ef3c5e8)</span></li>

 <li>mimetypes/CMakeLists.txt <span style="color: grey">(003951e)</span></li>

 <li>solid/solid/CMakeLists.txt <span style="color: grey">(b7dcc97)</span></li>

 <li>sonnet/plugins/CMakeLists.txt <span style="color: grey">(9d69005)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108002/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>