<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107049/">http://git.reviewboard.kde.org/r/107049/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 27th, 2012, 1:32 p.m., <b>Alexander Neundorf</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Have a look at http://www.cmake.org/Wiki/CMake_Released_Versions and/or http://www.cmake.org/Wiki/CMake_Version_Compatibility_Matrix , to find out what changed in which version of CMake.
Beside that, I can't really comment on the python-related changes, I don't know much about python.
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks like some of the things I'm using require cmake > 2.8.0. Thus, if you agree with this patch, I'll merge things in master only after Tuesday, after your cmake version bump.</pre>
<br />
<p>- Luca</p>
<br />
<p>On October 26th, 2012, 9:50 a.m., Luca Beltrame wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Build System.</div>
<div>By Luca Beltrame.</div>
<p style="color: grey;"><i>Updated Oct. 26, 2012, 9:50 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix CMake Python macros.
The internal CMake macros in kdelibs for Python are a
mess, and make installing for different Python versions (2 and 3) very
hard, especially since some distributions change the Python library name
slightly.
The fix is to use proper CMake macros from upstream, FindPythonInterp
and FindPythonLibs.
However I'm not sure in which CMake versions these are. If it's 2.6.x, I'll also push to stable branch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled with Python 3 and Python 2.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(af7a81573408952240517735ea3f4107a9be77e8)</span></li>
<li>kpythonpluginfactory/CMakeLists.txt <span style="color: grey">(41fa0fed576cafacc4cdaa4f7ca657b41c7beba3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107049/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>