
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" "http://www.w3.org/TR/REC-html40/strict.dtd">

<html><head><meta name="qrichtext" content="1" /><style type="text/css">

p, li { white-space: pre-wrap; }

</style></head><body style=" font-family:'Verdana'; font-size:10pt; font-weight:400; font-style:normal;">

<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">On Monday, April 16, 2012 04:29:01 PM Michael Jansen wrote:<br /></p>

<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; "> </p>

<table border="0" style=" margin-top:0px; margin-bottom:0px; margin-left:40px; margin-right:40px;" width="100%" cellspacing="2" cellpadding="8" bgcolor="#f9f3c9">

<tr>

<td>

<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><span style=" font-family:'Verdana,Arial,Helvetica,Sans-Serif';">This is an automatically generated e-mail. To reply, visit: </span><a href="http://git.reviewboard.kde.org/r/104619/"><span style=" font-family:'Verdana,Arial,Helvetica,Sans-Serif'; text-decoration: underline; color:#0057ae;">http://git.reviewboard.kde.org/r/104619/</span></a><span style=" font-family:'Verdana,Arial,Helvetica,Sans-Serif';"> </span></p></td></tr></table>

<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><span style=" font-family:'Verdana,Arial,Helvetica,Sans-Serif';"><br /></span></p>

<table border="0" style=" margin-top:0px; margin-bottom:0px; margin-left:40px; margin-right:40px;" width="100%" cellspacing="0" cellpadding="8" bgcolor="#fefadf">

<tr>

<td background="http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png">

<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><span style=" font-family:'Verdana,Arial,Helvetica,Sans-Serif';">Review request for Build System.</span></p>

<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><span style=" font-family:'Verdana,Arial,Helvetica,Sans-Serif';">By Michael Jansen. </span></p>

<p style=" margin-top:12px; margin-bottom:12px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><span style=" font-family:'Verdana,Arial,Helvetica,Sans-Serif'; font-style:italic; color:#808080;">Updated April 16, 2012, 4:29 p.m.</span><span style=" font-family:'Verdana,Arial,Helvetica,Sans-Serif';"> </span></p>

<p style=" margin-top:20px; margin-bottom:12px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><span style=" font-family:'Verdana,Arial,Helvetica,Sans-Serif'; font-size:xx-large; font-weight:600; color:#575012;">Description </span></p>

<table border="0" style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px;" width="100%" cellspacing="0" cellpadding="10" bgcolor="#ffffff">

<tr>

<td background="http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png">

<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><span style=" font-family:'Courier New,courier';">Remove checks for sip, pyqt4 and pykde4. They are unneeded.</span></p>

<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; "> </p>

<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><span style=" font-family:'Courier New,courier';">Correct fix for the given bug.</span></p>

<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; "> </p>

<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><span style=" font-family:'Courier New,courier';">BUG: 221501</span><span style=" font-family:'Verdana,Arial,Helvetica,Sans-Serif';"> </span></p></td></tr></table>

<p style=" margin-top:20px; margin-bottom:12px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><span style=" font-family:'Verdana,Arial,Helvetica,Sans-Serif'; font-size:xx-large; font-weight:600; color:#575012;">Testing (updated)</span></p>

<table border="0" style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px;" width="100%" cellspacing="0" cellpadding="10" bgcolor="#ffffff">

<tr>

<td background="http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png">

<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><span style=" font-family:'Courier New,courier';">Reconfigured and compiled.</span><span style=" font-family:'Verdana,Arial,Helvetica,Sans-Serif';"> </span></p></td></tr></table>

<p style=" margin-top:20px; margin-bottom:12px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><span style=" font-family:'Verdana,Arial,Helvetica,Sans-Serif'; font-size:xx-large; font-weight:600; color:#575012;">Diffs </span></p>

<ul style="margin-top: 0px; margin-bottom: 0px; margin-right: 0px; -qt-list-indent: 1;"><li style=" font-family:'Verdana,Arial,Helvetica,Sans-Serif';" style=" margin-top:12px; margin-bottom:0px; margin-left:39px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">CMakeLists.txt <span style=" color:#808080;">(1385cb6a93568bb9c175a4c9d715e57cacb0f291)</span> </li>

<li style=" font-family:'Verdana,Arial,Helvetica,Sans-Serif';" style=" margin-top:0px; margin-bottom:12px; margin-left:39px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">plasma/generic/scriptengines/CMakeLists.txt <span style=" color:#808080;">(a157f437870c98194a9d7966bd7a227a68bd602f)</span> </li></ul>

<p style=" margin-top:12px; margin-bottom:12px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><a href="http://git.reviewboard.kde.org/r/104619/diff/"><span style=" font-family:'Verdana,Arial,Helvetica,Sans-Serif'; text-decoration: underline; color:#0057ae;">View Diff</span></a><span style=" font-family:'Verdana,Arial,Helvetica,Sans-Serif';"> </span></p></td></tr></table>

<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br /><br /></p>

<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">Another question. This patch makes it necessary for opensuse to adapt their package. The have a patch that ceases to work after we fixed this correctly. Is there a mailing list i should cc on commit?</p>

<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; "> </p>

<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">Mike</p>

<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; "> </p>

<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">-- </p>

<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">Michael Jansen</p>

<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">http://michael-jansen.biz</p></body></html>