<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=ISO-8859-6">
</head>
<body bgcolor="#ffffff" text="#000000">
On 08/17/2011 01:24 AM, Alexander Neundorf wrote:
<blockquote id="mid_201108170124_22030_neundorf_kde_org"
cite="mid:201108170124.22030.neundorf@kde.org" type="cite">
<meta name="qrichtext" content="1">
<style type="text/css">#mid_201108170124_22030_neundorf_kde_org p,
#mid_201108170124_22030_neundorf_kde_org li { white-space: pre-wrap; }
</style>
<p style="margin: 0px; text-indent: 0px;">On Tuesday 16 August
2011, Valentin Rusu wrote:</p>
<p style="margin: 0px; text-indent: 0px;">> Hello,</p>
<p style="margin: 0px; text-indent: 0px;">> The
SuperBuild.cmake file includes a SuperBuildOptions.cmake
optional file.</p>
<p style="margin: 0px; text-indent: 0px;">> As I understand,
this file is intended to hold the settings specific to my</p>
<p style="margin: 0px; text-indent: 0px;">> setup, globally. If
I put it next to the SuperBuild.cmake file, it won't</p>
<p style="margin: 0px; text-indent: 0px;">> get included. If I
put it under some subdirectory (say kdesupport), then</p>
<p style="margin: 0px; text-indent: 0px;">> it gets included.
But in this case I should repeat it in every sibling</p>
<p style="margin: 0px; text-indent: 0px;">> subdirectory, and
that's error prone IMO. Is this the intended design? </p>
<p style="margin: 0px; text-indent: 0px;">Yes, but, your argument
is good.</p>
<p style="margin: 0px; text-indent: 0px;">> If yes, will that
be possible to add another include for a global options</p>
<p style="margin: 0px; text-indent: 0px;">> file ? If not,
well, I already commited a change to the include directive</p>
<p style="margin: 0px; text-indent: 0px;">> that get's the
SuperBuildOptions.cmake from the main directory where</p>
<p style="margin: 0px; text-indent: 0px;">> SuperBuildcmake
sits.</p>
<p style="margin: 0px; text-indent: 0px;">That's ok.</p>
<p style="margin: 0px; text-indent: 0px;">Maybe trying to include
both makes sense ?</p>
</blockquote>
Yes, good idea!<br>
<blockquote id="mid_201108170124_22030_neundorf_kde_org"
cite="mid:201108170124.22030.neundorf@kde.org" type="cite">
<p style="margin: 0px; text-indent: 0px;">include(../SuperBuildOptions.cmake
OPTIONAL)</p>
<p style="margin: 0px; text-indent: 0px;">include(SuperBuildOptions.cmake
OPTIONAL)</p>
<p style="margin: 0px; text-indent: 0px;">Or should they have
different names then ?</p>
<p style="margin: 0px; text-indent: 0px;">Like, e.g.
GlobalSuperBuildOptions.cmake ?</p>
</blockquote>
I'd go for ProjectSuperBuildOptions.cmake in the project's child
directory and GlobalSuperBuildOptions.cmake in the main directory.<br>
If you agree, I could commit this :<br>
<br>
include(../GlobalSuperBuildOptions.cmake OPTIONAL)<br>
include(ProjectSuperBuildOptions.cmake OPTIONAL)<br>
<br>
That will leave place to define the per/project SB_ macros described
on the project's page.<br>
<br>
<pre class="moz-signature" cols="72">--
Valentin Rusu (valir)
KSecretsService (former KSecretService, KWallet replacement)
</pre>
</body>
</html>