<html><head><meta name="qrichtext" content="1" /></head><body style="font-size:9pt;font-family:Monospace">
<p>On Monday 14 March 2011, Michael Jansen wrote:</p>
<p>> Find attached what i have so far. It is not active or documented yet. Just</p>
<p>> for a review of the general logic.</p>
<p>></p>
<p>> I found a problem (or overanalyze here). How can i find out if the</p>
<p>> installation prefix of ruby is the same as the installation prefix of cmake</p>
<p>> if autoconf (ruby uses it) provides --exec_prefix, --prefix and --libdir</p>
<p>> options?</p>
<p>></p>
<p>> Perhaps just compare rbcofigs prefix and CMAKE_INSTALL_PREFIX and be done?</p>
<p>> If someone plays with those options (s)he deserves the problems?</p>
<p>></p>
<p>> Mike</p>
<p></p>
<p></p>
<p>0002-Reorder-stuff-in-the-hope-it-is-more-readable-and-un.patch</p>
<p>I don't think this patch improves readability.</p>
<p></p>
<p>0003-More-commenting.patch</p>
<p>IMHO this one doesn't really improve the comments. </p>
<p></p>
<p>-# if ruby > 1.8 is required or if ruby > 1.8 was found, search for the config.h dir</p>
<p>+#</p>
<p>+### FIND THE CONFIG.H FILE (IF > RUBY 1.8)</p>
<p>+#</p>
<p>IMO not better than before.</p>
<p></p>
<p>+#</p>
<p>+### CALL FindPackageHandleStandardArgs</p>
<p>+#</p>
<p> INCLUDE(FindPackageHandleStandardArgs)</p>
<p> SET(_RUBY_REQUIRED_VARS RUBY_EXECUTABLE RUBY_INCLUDE_DIR RUBY_LIBRARY)</p>
<p></p>
<p>This comment doesn't add any information.</p>
<p></p>
<p>And why are they all UPPERCASE ?</p>
<p></p>
<p>0004-1st-Step-Construct-the-custom-installation-area.patch</p>
<p>Looks good.</p>
<p></p>
<p>0005-2nd-step-Implement-the-logic.patch</p>
<p>Looks ok IMO.</p>
<p></p>
<p>Alex</p>
<p></p>
</body></html>