<div class="gmail_quote">2010/8/27 Maciej Mrozowski <span dir="ltr"><<a href="mailto:reavertm@gmail.com">reavertm@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im">On Thursday 26 of August 2010 20:59:21 Paulo Rômulo wrote:<br>
<br>
> > > I'm intending to add the attached file to kdelibs/cmake/modules in<br>
> > > order to conditionally build the Solid UPnP backend.<br>
<br>
</div>Using find_package(xxx) alone introduces automagic dependency (dependency that<br>
is determined at build time and cannot be overriden by the means of cmake<br>
configure options). Also commit message<br>
"Building Solid UPnP backend by default now. HUPnP library required." doesn't<br>
exactly say hupnp library is an optional dependency for kdelibs so it's not<br>
clear what your intentions really are.<br>
<br></blockquote><div>Sorry for that. And, yes, it is an optional dependency.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
So, if HUPnp backend is indeed meant to be optional:<br>
- replace find_package with macro_optional_find_package (adds WITH_HUpnp CMake<br>
variable to switch on/off this dependency)<br>
- add macro_log_feature just below macro_optional_find_package(HUpnp) - in<br>
such case message(STATUS "Building Solid UPnP backend." ) can be dropped<br>
(macro_log_feature will take the role of informing about that)<br>
<br></blockquote><div>Done. Please, tell me if it's fine now.</div><div><br></div><div>Thanks,</div><div><br></div><div>Paulo.</div></div>