D16954: Add find module for Google's libphonenumber

Christophe Giboudeaux noreply at phabricator.kde.org
Sat Dec 1 21:16:49 GMT 2018


cgiboudeaux added inline comments.

INLINE COMMENTS

> cgiboudeaux wrote in FindPhoneNumber.cmake:85
> phonenumber doesn't install a pkg-config file, this variable is empty

Note: this is harmless, but maybe just add

  set(PhoneNumber_VERSION 0)

to make it clear. AFAICS, none of the public headers contain the library version

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D16954

To: vkrause, #build_system, #frameworks
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20181201/f2037e9c/attachment.html>


More information about the Kde-buildsystem mailing list