Review Request 121971: Fix CMP0053 warning with CMake 3.1.

Alex Merry alex.merry at kde.org
Wed Jan 14 22:19:02 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121971/
-----------------------------------------------------------

(Updated Jan. 14, 2015, 10:19 p.m.)


Status
------

This change has been marked as submitted.


Review request for Extra Cmake Modules and David Faure.


Repository: extra-cmake-modules


Description
-------

With CMake 3.1, @-style variable expansion is deprecated outside of
configure_file() or string(CONFIGURE) contexts (CMP0053). This causes
ecm_generate_pri_file() to produce dev warnings with this verison of
CMake, and would break this function in projects that set CMake 3.1 as
their required version.


Diffs
-----

  modules/ECMGeneratePriFile.cmake b353e867586346a10e0f8df77b81ff83993ae497 

Diff: https://git.reviewboard.kde.org/r/121971/diff/


Testing
-------

Attica still configures and builds, and produces the same .pri file it did before.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20150114/d6ea44fb/attachment.html>


More information about the Kde-buildsystem mailing list