Review Request 117581: Deprecate ecm_dbus_add_activation_service()

Alex Merry alex.merry at kde.org
Wed Apr 16 10:11:44 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117581/
-----------------------------------------------------------

Review request for Build System, Extra Cmake Modules and KDE Frameworks.


Repository: extra-cmake-modules


Description
-------

Deprecate ecm_dbus_add_activation_service()

This is a bit of a pointless macro: it can be replaced with two lines
for each input file (and it is usually only called with a single input
file), and it is much clearer what those two lines do.


Diffs
-----

  modules/ECMDBusAddActivationService.cmake 128482e35f9f15025868f3e283db839556a0ce82 

Diff: https://git.reviewboard.kde.org/r/117581/diff/


Testing
-------

Built documentation; built and installed KWallet (one of the two users of this macro).


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140416/1ebbe7c9/attachment.html>


More information about the Kde-buildsystem mailing list