Review Request 112912: Skip cmake checks for C and C++ compilers

Nicolás Alvarez nicolas.alvarez at gmail.com
Wed Sep 25 21:23:51 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112912/#review40829
-----------------------------------------------------------

Ship it!


I approve! Especially on Windows where the compiler check is noticeably slower than on Linux.

- Nicolás Alvarez


On Sept. 24, 2013, 7:32 a.m., Daniele E. Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112912/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2013, 7:32 a.m.)
> 
> 
> Review request for Build System.
> 
> 
> Description
> -------
> 
> Skip cmake checks for C and C++ compilers
> 
> These are not needed, since there are no files to build, and just slow down the execution of cmake
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d9a1405b959617f1775ced1b999f17f2b6e14ffe 
> 
> Diff: http://git.reviewboard.kde.org/r/112912/diff/
> 
> 
> Testing
> -------
> 
> cmake, make and make install still work
> 
> 
> Thanks,
> 
> Daniele E. Domenichelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20130925/ec550e5d/attachment.html>


More information about the Kde-buildsystem mailing list