Review Request: Fix the PopplerQt4 detection when using set_package_properties

Christophe Giboudeaux cgiboudeaux at gmx.com
Fri Dec 28 18:26:53 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107987/
-----------------------------------------------------------

Review request for Build System and Alexander Neundorf.


Description
-------

set_package_properties expects the _FOUND variable to match the find module name.
This patch adds PopplerQt4_FOUND and deprecates POPPLER_QT4_FOUND


Diffs
-----

  cmake/modules/FindPopplerQt4.cmake f2a59b8 

Diff: http://git.reviewboard.kde.org/r/107987/diff/


Testing
-------

project(test)
cmake_minimum_required(VERSION 2.8.9)
find_package(KDE4 REQUIRED)
include(KDE4Defaults)
find_package(PopplerQt4 MODULE)
set_package_properties(PopplerQt4 PROPERTIES TYPE REQUIRED)
feature_summary(WHAT ALL FATAL_ON_MISSING_REQUIRED_PACKAGES)

works with this patch


Thanks,

Christophe Giboudeaux

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20121228/257e0e53/attachment.html>


More information about the Kde-buildsystem mailing list