[PATCH] Beautified MacroLogFeature

[Sebastian Trüg]

On Thursday 19 February 2009 14:19:15 Allen Winter wrote:
> On Thursday 19 February 2009 7:52:22 am Sebastian Trüg wrote:
> > On Thursday 19 February 2009 12:25:59 David Faure wrote:
> > > On Thursday 19 February 2009, Sebastian Trüg wrote:
> > > > Please find attached a patch to MacroLogFeature which IMHO makes for
> > > > a much nicer output than the current version.
> > >
> > > Can you show an example of what the output looks like?
> > > Thanks.
> >
> > sure, sorry.
> >
> > -------------------------------------------------------------------------
> >---- -- Configuration Summary:
> > -------------------------------------------------------------------------
> >----
> >
> >   
> > -------------------------------------------------------------------------
> >- The following external packages were located on your system.
> >    This installation will have the extra features provided by these
> > packages.
> > -------------------------------------------------------------------------
> >-
> >
> >    * libDVDRead
> >      Libdvdread provides a simple foundation for reading DVD video disks.
> >
> >    * Musicbrainz
> >      Provide information about the CD, about the artist or about related
> >      information
> >
> >    * KCddb
> >      KCddb is used to retrieve audio CD meta data from the internet.
> >
> >    * FFmpeg
> >      Needed for the K3b FFmpeg decoder plugin which can decode virtually
> > all audio types.
> >
> >    * Flac
> >      Needed for the Flac audio decoder plugin.
> >
> >    * Flac++
> >      Needed for the Flac audio decoder plugin.
> >
> >    * Mad mp3
> >      Needed for the mp3 audio decoder plugin.
> >
> >    * Muse
> >      Needed for the Musepack audio decoder plugin
> >
> >    * Sndfile
> >      Needed for the libsndfile audio decoder plugin.
> >
> >    * Lame mp3 encoder
> >      Needed for the lame mpf encoder encoder plugin.
> >
> >    * Ogg Vorbis
> >      Needed for the K3b Ogg Vorbis decoder and encoder plugins.
>
> When we wrote the original MacroLogFeature, we got complaints that
> there was too much info printed for the stuff that was successfully
> located. So that's why we have the current "compressed" list, with only
> 1-line per feature.  I'd like to keep that.  but appending the comment to
> each line might be a good idea.

hm, so how about a new version then? Something like 
macro_display_feature_log_full?

> >   
> > -------------------------------------------------------------------------
> >- The following OPTIONAL packages could NOT be located on your system.
> > Consider installing them to enable more features from this software.
> > -------------------------------------------------------------------------
> >-
> >
> >    * Taglib (1.4.0 or higher)  <http://www.freshmeat.net/projects/taglib>
> >      Read and write tags in audio files
>
> I think we need the comment printed so people know what they are missing
> if they don't install the feature.

it is printed. I simply did not add a comment here.