<div dir="ltr">And now <a href="https://github.com/ShaheedHaque/extra-cmake-modules/pull/4.">https://github.com/ShaheedHaque/extra-cmake-modules/pull/4.</a>..<br><div class="gmail_extra"><br><div class="gmail_quote">On 30 January 2017 at 22:17, Shaheed Haque <span dir="ltr"><<a href="mailto:srhaque@theiet.org" target="_blank">srhaque@theiet.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I also put out <a href="https://github.com/ShaheedHaque/extra-cmake-modules/pull/3" target="_blank">https://github.com/<wbr>ShaheedHaque/extra-cmake-<wbr>modules/pull/3</a>.<br><br></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On 29 January 2017 at 21:09, Shaheed Haque <span dir="ltr"><<a href="mailto:srhaque@theiet.org" target="_blank">srhaque@theiet.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>OK, let's start small: <a href="https://github.com/ShaheedHaque/extra-cmake-modules/pull/2" target="_blank">https://github.com/ShaheedHaqu<wbr>e/extra-cmake-modules/pull/2</a>.<br><br></div>Please review...<br></div><div class="m_2249465440063826934HOEnZb"><div class="m_2249465440063826934h5"><div class="gmail_extra"><br><div class="gmail_quote">On 29 January 2017 at 17:12, Stephen Kelly <span dir="ltr"><<a href="mailto:steveire@gmail.com" target="_blank">steveire@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>Shaheed Haque wrote:<br>
<br>
> Rewrite? It think its more a case of forking making things diverge (if you<br>
> look, a lot of the changes are formatting, name changes and comments,<br>
> though I accept that does make for a lot of noise). I have tried VERY hard<br>
> to keep the good changes form both sides...and yes, there ARE a reasonable<br>
> number of actual changes too.<br>
><br>
> Anyway, I was under the impression a squashed single commit was preferred,<br>
> but I can look to pull things out again. I would prefer to work the<br>
> reviews via github's Pull Requests, is that still OK?<br>
<br>
</span>Yep, sounds good to me!<br>
<br>
Thanks,<br>
<br>
Steve.<br>
<br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div></div>