<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127705/">https://git.reviewboard.kde.org/r/127705/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1 to me, it does seem harmless. I'll wait for people from other distros to comment before giving a Ship it.</p></pre>
<br />
<p>- Luca Beltrame</p>
<br />
<p>On aprile 21st, 2016, 8:24 p.m. CEST, Wolfgang Bauer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Bindings, Scott Kitterman and Luca Beltrame.</div>
<div>By Wolfgang Bauer.</div>
<p style="color: grey;"><i>Updated Apr. 21, 2016, 8:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
pykde4
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">About 2 months ago, the build started to fail in openSUSE Factory.
We got these build errors:
[ 237s] CMakeFiles/python_module_PyKDE4_dnssd.dir/sip/dnssd/sipdnssdpart2.cpp.o: In function `meth_DNSSD_ServiceBrowser_resolveHostName':
[ 237s] /home/abuild/rpmbuild/BUILD/pykde4-4.14.3/build/sip/dnssd/sipdnssdpart2.cpp:408: undefined reference to `QHostAddress::QHostAddress(QHostAddress const&)'
[ 237s] /home/abuild/rpmbuild/BUILD/pykde4-4.14.3/build/sip/dnssd/sipdnssdpart2.cpp:408: undefined reference to `QHostAddress::~QHostAddress()'
[ 237s] collect2: error: ld returned 1 exit status
...
[ 287s] CMakeFiles/python_module_PyKDE4_kio.dir/sip/kio/sipkiopart3.cpp.o: In function `meth_KFilePlacesModel_deviceForIndex':
[ 287s] /home/abuild/rpmbuild/BUILD/pykde4-4.14.3/build/sip/kio/sipkiopart3.cpp:18560: undefined reference to `Solid::Device::Device(Solid::Device const&)'
[ 287s] /home/abuild/rpmbuild/BUILD/pykde4-4.14.3/build/sip/kio/sipkiopart3.cpp:18560: undefined reference to `Solid::Device::~Device()'
[ 287s] CMakeFiles/python_module_PyKDE4_kio.dir/sip/kio/sipkiopart4.cpp.o: In function `meth_KDeviceListModel_deviceForIndex':
[ 287s] /home/abuild/rpmbuild/BUILD/pykde4-4.14.3/build/sip/kio/sipkiopart4.cpp:27090: undefined reference to `Solid::Device::Device(Solid::Device const&)'
[ 287s] /home/abuild/rpmbuild/BUILD/pykde4-4.14.3/build/sip/kio/sipkiopart4.cpp:27090: undefined reference to `Solid::Device::~Device()'
[ 287s] collect2: error: ld returned 1 exit status
This patch fixes them.
I'm not sure why this suddenly started to happen or whether it could be a problem in other distributions as well, but I was asked to offer the patch upstream, and it shouldn't harm anyway I think.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">builds fine now on openSUSE Factory</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(b0768cf)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127705/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>