<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119453/">https://git.reviewboard.kde.org/r/119453/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Bindings, Scott Kitterman, Luca Beltrame, Andrea Scarpino, and Simon Edwards.</div>
<div>By Raphael Kubo da Costa.</div>
<p style="color: grey;"><i>Updated July 29, 2014, 5:07 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=327633">327633</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
pykde4
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">PyQt's pyqtconfig was deprecated in version 4.10, and is not installed<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
if PyQt's new build system is used.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">PyKDE itself provides a pykdeconfig module that inherits from pyqtconfig<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
and allows users of the SIP build system to obtain information about how<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
PyKDE was configured and generate Makefiles from it. It is also used by<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
kdelibs's FindPyKDE4.cmake for the same purposes.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Even though the information provided by PyKDE exists regardless of<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
pyqtconfig, insisting on pykdeconfig goes against the design of PyQt's<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
new build system.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Instead, we now do something similar to PyQt itself: while it provides a<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
PYQT_CONFIGURATION dict with (at the moment) a single key with the SIP<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
flags used to build PyQt, we provide PyKDE4.kdecore.PYKDE_CONFIGURATION,<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
a dict containing the SIP flags used to build PyKDE and, in addition to<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
that, the directory where PyKDE's SIP files have been installed. This<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
new dict exists regardless of how PyQt was built.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Finally, this commit does not remove pykdeconfig.py, but rather makes<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
its installation depend on whether pyqtconfig.py has been found at<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
configuration time.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">PyKDE built fine without pyqtconfig, and with my fix to FindPyKDE4.cmake (#119454) Kate's Pate plugin works fine without neither pyqtconfig nor pykdeconfig present.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(5233da8d94b4bbbbb72a2594c692db9022628f23)</span></li>
<li>PyKDEConfigurationInformation.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>sip/kdecore/kdecoremod.sip <span style="color: grey">(05b5baceb8e98a49af4a1e84c59698f84a4daf48)</span></li>
<li>sip/kdecore/pykde_config.sip.in <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119453/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>