<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115082/">https://git.reviewboard.kde.org/r/115082/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit ce222ff83e583baad58045cfae4a7dd63e35f4b0 by Fabian Kosmale to branch KDE/4.12.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On January 17th, 2014, 9:18 p.m. UTC, Fabian Kosmale wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Bindings, Luca Beltrame and Simon Edwards.</div>
<div>By Fabian Kosmale.</div>
<p style="color: grey;"><i>Updated Jan. 17, 2014, 9:18 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=326294">326294</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
pykde4
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">With recent versions of PyQt (at least 4.10.3), the compileUI's signature has changed from
def compileUi(self, input_stream, output_stream, from_imports):
to
def compileUi(self, input_stream, output_stream, from_imports, resource_suffix):
As mentioned in the bug report, this prevents pykdeuic4 from working. The attached patch is not a final version, but more a starting point: It just passes an empty string as the last parameter. This will however break with older versions of PyQt as far as I can see. Would catching the TypeError and then calling the version with the empty string be a solution (easier to ask for forgiveness than for permission)? Or is this considered too hackish? Alternatively, one could probably choose a function based on QtCore.PYQT_VERSION_STR. Any other ideas?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Our (Chakra Linux's) greeter application, Kapudan, a fork of Pardus's Kaptan which requires pykdeuic4 builds; so does the dummy file attached in the linked bug.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tools/pykdeuic4/pykdeuic4.py <span style="color: grey">(491985a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115082/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>