<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109705/">http://git.reviewboard.kde.org/r/109705/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 25th, 2013, 5:32 p.m. UTC, <b>Michael Jansen</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is this compatible to ruby 1.8 AND 1.9? Or does it stop working with 1.8 after this?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am not sure if this one still works with Ruby 1.8. openSUSE stopped shipping Ruby 1.8 about 1 year ago, so I can not test it. However the question would be if distro's are still shipping ruby 1.8 by default or just to keep this building.
Therefore I raised the Ruby requirements to ruby 1.9 </pre>
<br />
<p>- Raymond</p>
<br />
<p>On March 25th, 2013, 1:47 p.m. UTC, Raymond Wooninck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Bindings, Michael Jansen and Sebastian Sauer.</div>
<div>By Raymond Wooninck.</div>
<p style="color: grey;"><i>Updated March 25, 2013, 1:47 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Patch to make kross-interpreters compile with Ruby 1.9.x. Patch was created by openSUSE, when Ruby 1.9.x was included in the main repositories. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ruby/CMakeLists.txt <span style="color: grey">(575a371)</span></li>
<li>ruby/rubyconfig.h <span style="color: grey">(66f1d45)</span></li>
<li>ruby/rubyextension.cpp <span style="color: grey">(10eb665)</span></li>
<li>ruby/rubyfunction.h <span style="color: grey">(d986392)</span></li>
<li>ruby/rubyobject.cpp <span style="color: grey">(2232311)</span></li>
<li>ruby/rubyscript.cpp <span style="color: grey">(6648db5)</span></li>
<li>ruby/rubyvariant.h <span style="color: grey">(630c0db)</span></li>
<li>ruby/rubyvariant.cpp <span style="color: grey">(90b5c62)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109705/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>