<html><body><div style="color:#000; background-color:#fff; font-family:times new roman, new york, times, serif;font-size:12pt"><span class="tab"> <br></span><div><span class="tab"> Mr. Crowell,</span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: times new roman,new york,times,serif; background-color: transparent; font-style: normal;"><span class="tab"> <br></span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: times new roman,new york,times,serif; background-color: transparent; font-style: normal;"><span class="tab"> Thanks for the patch, it looks n</span>ice. I'll discuss it in a while. First, I'd like to point out that there is no need for us here in open source communities to be that formal. :) If you agree with me, you may call me "Dimitar" and in turn I would call you "Brian". However, if you do prefer an official form of address,
that's fine by me.</div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: times new roman,new york,times,serif; background-color: transparent; font-style: normal;"><span class="tab"> About your patch: it looks very good, and I like how you reused the method for generating a property instead of writing your own. :) However, I have two remarks, a regression and a suggestion:</span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: times new roman,new york,times,serif; background-color: transparent; font-style: normal;"><span class="tab"> 1. QComboBox.Model used to be a read-write property, now it's read only. Could you please change </span><span class="tab">your code so that it remains read-write? Also, if possible, check for other such cases because this is simply one I found, it doesn't mean there aren't more;</span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family:
times new roman,new york,times,serif; background-color: transparent; font-style: normal;"><span class="tab"> 2. </span>I'm wondering if it would be better to have something like a list of commonly used in API-s verbs, and then if the method starts with has or is or is a single word (this can be checked by casing) and this single word is not a verb, the method should be generated as a property. The thing is that your way you have to look for properties all over the huge Qt API, and that with each Qt version (for example, Qt 5 is coming very soon). Of course, the verb approach may actually turn out to be worse because there may be way too many verbs to enumerate. So this is simply a suggestion for you to think about if you like.<br><span class="tab"> <br></span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: times new roman,new york,times,serif; background-color: transparent; font-style:
normal;"><span class="tab"> </span><span class="tab">Dimitar<br></span></div><div><br></div> <div style="font-family: times new roman, new york, times, serif; font-size: 12pt;"> <div style="font-family: times new roman, new york, times, serif; font-size: 12pt;"> <div dir="ltr"> <font face="Arial" size="2"> <hr size="1"> <b><span style="font-weight:bold;">From:</span></b> "Crowell, Brian" <BCrowell@barbnet.com><br> <b><span style="font-weight: bold;">To:</span></b> KDE bindings for other programming languages <kde-bindings@kde.org> <br> <b><span style="font-weight: bold;">Sent:</span></b> Thursday, December 13, 2012 8:23 PM<br> <b><span style="font-weight: bold;">Subject:</span></b> [Kde-bindings] Qyoto: Patch v1: Translate obvious getters into properties or "Get" methods<br> </font> </div> <br>
As discussed with Mr. Dobrev, this patch finds methods with certain names and signatures and translates them into properties. This covers "Is" and "Has" properties along with a specified list of noun phrases. Getter methods that take arguments are renamed "Get" (Sibling(int row, int column) becomes GetSibling(int row, int column)).<br><br>The list of property names is incomplete. I'll add more as I find them.<br><br>--Brian<br>_______________________________________________<br>Kde-bindings mailing list<br><a ymailto="mailto:Kde-bindings@kde.org" href="mailto:Kde-bindings@kde.org">Kde-bindings@kde.org</a><br><a href="https://mail.kde.org/mailman/listinfo/kde-bindings" target="_blank">https://mail.kde.org/mailman/listinfo/kde-bindings</a><br><br><br> </div> </div> </div></body></html>