[Kde-bindings] Patches for smokegen/smokeqt/qyoto under Windows (almost done!)

[Dimitar Dobrev]

Last night I committed (as I said I would) some now conflicting changes to the CMakeLists. All:

INSTALL(TARGETS qyoto-<lib>-native LIBRARY DESTINATION lib)

were turned to:


INSTALL(TARGETS qyoto-<lib>-native LIBRARY DESTINATION ${LIB_INSTALL_DIR}
                                      ARCHIVE DESTINATION ${LIB_INSTALL_DIR}
                                      RUNTIME DESTINATION lib)

The difference with Steven's patches is that he uses RUNTIME DESTINATION *bin*. I pushed "lib" because otherwise everything would go to /bin also on the Unix platforms (Linux, Mac) and that is against the Unix standards. Sorry for any inconvenience but, as I said, yesterday I mailed I'd commit Steven's changes and a minute later sent a follow-up that I'd replace "bin" with "lib" in his code.



________________________________
 From: Arno Rehn <arno at arnorehn.de>
To: KDE bindings for other programming languages <kde-bindings at kde.org> 
Sent: Thursday, December 8, 2011 5:44 PM
Subject: Re: [Kde-bindings] Patches for smokegen/smokeqt/qyoto under Windows (almost done!)
 
On Wednesday 07 December 2011 18:39:49 Steven Boswell II wrote:
> Enclosed is an archive of my latest patches to smokegen, smokeqt, and qyoto,
> against the latest version of the code in the git repositories.
> 
> Now all the DLLs are put into the "bin" directory (to minimize the number of
> directories that have to be added to the Windows system path), and "lib" is
> no longer prepended to the beginning of DLL/archive names.  No files are
> moved under Linux; the generated directory tree has the same layout.
> 
> 
> But there's one problem I can't solve.  Look at line 107 of
> qyoto-windows.patch.  I removed that line because otherwise, the Windows
> CMake dies during generation with:
> 
> CMake Error: INSTALL(EXPORT "QyotoExport") given absolute DESTINATION
> "C:/Program Files (x86)/qyoto/share/qyoto/cmake" but the export references
> an installation of target "qyoto" which has relative DESTINATION "bin".
> 
> But removing that line also causes SmokeExport.cmake and
> SmokeExport-release.cmake to not get installed in the Linux version, and
> presumably in the Windows version.  With that line restored (i.e. if the
> patch file is altered to not remove that line), the Linux version builds
> fine, and SmokeExport.cmake and SmokeExport-release.cmake are in the
> installed directory tree.
> 
> Does anyone know how to solve this?  Apart from this issue, I think my
> changes are ready to check in.
First, thanks for the patches :)
To solve the problem, I thank that you either have to make the DESTINATION 
argument of the INSTALL(EXPORT ...) line relative (i.e. just make it 
"share/qyoto/cmake"), or make all reference to the "bin" DESTINATION absolute 
by saying "${CMAKE_INSTALL_PREFIX}/bin".

-- 
Arno Rehn
_______________________________________________
Kde-bindings mailing list
Kde-bindings at kde.org
https://mail.kde.org/mailman/listinfo/kde-bindings
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-bindings/attachments/20111208/22b7b6fd/attachment.html>