[Kde-bindings] [PATCH] [CMake] Smoke - flexible handling of what to build and what not to

Maciej Mrozowski reavertm at gmail.com
Sun May 9 05:39:46 UTC 2010


My initial problem was to allow not building some SMOKE bindings (like 
QtMultimedia, QtWebkit and such which now are mandatory dependencies), then 
I've decided to come up with something to reduce copy&paste in toplevel Smoke 
CMakeLists.txt and possible increase manageability.

Changes:
- introduce macro smoke_add_bindings(<var> <name> <subdir1> [subdir2 ...]) - 
it's basically a little smarter version of macro_optional_add_subdirectory
In this macro, I've also added CMake option to disable particular bindings 
(DISABLE_SMOKE_<sth> is more correct than ENABLE_SMOKE_<sth> because with the 
latter one cannot really assure than all satisfied deps are found, and 
disabling always works)
- use macro instead of set(SMOKE_ENABLED... ) and add_subdirectory(...)

Ok to commit?

-- 
regards
MM
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdebindings.diff
Type: text/x-patch
Size: 7236 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-bindings/attachments/20100509/262c4e70/attachment.diff>


More information about the Kde-bindings mailing list