<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106041/">http://git.reviewboard.kde.org/r/106041/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 25th, 2012, 5:59 p.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Today is soft feature freeze. What is the state of the library? Is it stable yet?</pre>
</blockquote>
<p>On January 13th, 2013, 8:39 a.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">master is open again, so what are the plans for this in the 4.11 time frame? If it's supposed to go in, I would prefer to see it go in rather soonish, then later in the cycle</pre>
</blockquote>
<p>On January 16th, 2013, 1:04 p.m. UTC, <b>Amandeep Singh</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">@Martin the library is stable, but it is still in playground.
I think we can go ahead with pushing these commits.</pre>
</blockquote>
<p>On January 16th, 2013, 1:16 p.m. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To Quote Martin's (the very first) comment on this:
"First of all: we cannot depend on anything in playground. This review has a push embargo till the library has gone through review."
If you rely this on playground, you force everyone compiling workspace master to track playground. That's simply not an option at all.
Where is the lib reviewed for a proper inclusion?</pre>
</blockquote>
<p>On January 16th, 2013, 3:14 p.m. UTC, <b>Sebastian Sauer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">iirc Fregl send a mail to core-devel a long while ago, feedback was addressed and the lib can be moved. As imho usual with trivial things that are going on over a long time period progress stopped at one time and things went into limbo. Hach :/
So, what we would need to do is to checkout the lib from playground, commit to git and push. That's it :)
@Fregl Ok if I do or was there something left I missed?
</pre>
</blockquote>
<p>On January 16th, 2013, 3:51 p.m. UTC, <b>Frederik Gladhorn</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">@Sebastian: please go ahead if you find the time, I have just been kept too busy.</pre>
</blockquote>
<p>On February 12th, 2013, 8:05 a.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">any update?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Turned out I am to busy too and lost quit a lot of my motivation by reading latest gsoc-statements. Sorry, not anytime soon.</pre>
<br />
<p>- Sebastian</p>
<br />
<p>On September 24th, 2012, 4:38 p.m. UTC, Amandeep Singh wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Accessibility, kwin, Frederik Gladhorn, Luboš Luňák, and Sebastian Sauer.</div>
<div>By Amandeep Singh.</div>
<p style="color: grey;"><i>Updated Sept. 24, 2012, 4:38 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch is for KWin, makes the focus-tracking feature of KWin work with applications. This makes KDE more accessible.
A new accessibility client library "libkdeaccessibilityclient" (which can be found here: https://projects.kde.org/projects/playground/accessibility/libkdeaccessibilityclient) is also to be added in kde-support.
The focus-tracking feature will use the new library to get the accessibility information from at-spi.
Adjustments in CMakeLists have been made to add the library as an optional dependency, which if found enables the focus-tracking option in Zoom Plugin.
And in absence of library, the option is removed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tested KWin's new feature working with KWrite and Konsole.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(451a8b9)</span></li>
<li>config-workspace.h.cmake <span style="color: grey">(4a2dcbf)</span></li>
<li>kwin/effects/CMakeLists.txt <span style="color: grey">(29accb1)</span></li>
<li>kwin/effects/configs_builtins.cpp <span style="color: grey">(b291e38)</span></li>
<li>kwin/effects/zoom/zoom.h <span style="color: grey">(d809b21)</span></li>
<li>kwin/effects/zoom/zoom.cpp <span style="color: grey">(b275b1e)</span></li>
<li>kwin/effects/zoom/zoom_config.cpp <span style="color: grey">(3edd10c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106041/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>