[Kde-accessibility] Review Request 106041: Focus Tracking in KWin's Zoom Plugin

[Thomas Lübking]

> On Oct. 25, 2012, 5:59 p.m., Martin Gräßlin wrote:
> > Today is soft feature freeze. What is the state of the library? Is it stable yet?
> 
> Martin Gräßlin wrote:
>     master is open again, so what are the plans for this in the 4.11 time frame? If it's supposed to go in, I would prefer to see it go in rather soonish, then later in the cycle
> 
> Amandeep Singh wrote:
>     @Martin the library is stable, but it is still in playground.
>     I think we can go ahead with pushing these commits.

To Quote Martin's (the very first) comment on this:

"First of all: we cannot depend on anything in playground. This review has a push embargo till the library has gone through review."

If you rely this on playground, you force everyone compiling workspace master to track playground. That's simply not an option at all.

Where is the lib reviewed for a proper inclusion?


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106041/#review20906
-----------------------------------------------------------


On Sept. 24, 2012, 4:38 p.m., Amandeep Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106041/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2012, 4:38 p.m.)
> 
> 
> Review request for KDE Accessibility, kwin, Frederik Gladhorn, Luboš Luňák, and Sebastian Sauer.
> 
> 
> Description
> -------
> 
> This patch is for KWin, makes the focus-tracking feature of KWin work with applications. This makes KDE more accessible.
> A new accessibility client library "libkdeaccessibilityclient" (which can be found here: https://projects.kde.org/projects/playground/accessibility/libkdeaccessibilityclient) is also to be added in kde-support.
> 
> The focus-tracking feature will use the new library to get the accessibility information from at-spi.
> 
> Adjustments in CMakeLists have been made to add the library as an optional dependency, which if found enables the focus-tracking option in Zoom Plugin.
> And in absence of library, the option is removed.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 451a8b9 
>   config-workspace.h.cmake 4a2dcbf 
>   kwin/effects/CMakeLists.txt 29accb1 
>   kwin/effects/configs_builtins.cpp b291e38 
>   kwin/effects/zoom/zoom.h d809b21 
>   kwin/effects/zoom/zoom.cpp b275b1e 
>   kwin/effects/zoom/zoom_config.cpp 3edd10c 
> 
> Diff: http://git.reviewboard.kde.org/r/106041/diff/
> 
> 
> Testing
> -------
> 
> I tested KWin's new feature working with KWrite and Konsole.
> 
> 
> Thanks,
> 
> Amandeep Singh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-accessibility/attachments/20130116/1b5791a6/attachment.html>