<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113295/">http://git.reviewboard.kde.org/r/113295/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 1st, 2013, 2:42 p.m. UTC, <b>Michael Pyne</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch works for me (though I also have a recent ffmpeg). I have some comments, but I'd say if no one with an old ffmpeg chimes in to confirm that this still compiles there I'd go ahead and commit. The compatibility wrappers with the old code appear correct at least.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I can confirm it (still) builds against ffmpeg-1.2.x with this patch.</pre>
<br />
<p>- Rex</p>
<br />
<p>On October 16th, 2013, 9:41 p.m. UTC, Michael Jansen wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for K3b.</div>
<div>By Michael Jansen.</div>
<p style="color: grey;"><i>Updated Oct. 16, 2013, 9:41 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
k3b
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix compiling k3b against latest ffmpeg. They once again broke source compatibility.
Thats two patches. Reviewboard made it into one. The MAX_AUDIO_FRAME thing is a separate patch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled against latest ffmpeg. Now i need someone with a ffpmpeg that still has CodecID to check if it still works.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(ca1531d8e601e423002f6ffa490f2d5bb8dbf5d8)</span></li>
<li>plugins/decoder/ffmpeg/k3bffmpegwrapper.h <span style="color: grey">(1ec36b6e465a08f7fe42c80b926e98683be75a5e)</span></li>
<li>plugins/decoder/ffmpeg/k3bffmpegwrapper.cpp <span style="color: grey">(a5ef087a5ac3a2dc8b7d385b9c3a2e16bf6622bb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113295/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>