<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101350/">http://git.reviewboard.kde.org/r/101350/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<p>- Sebastian</p>
<br />
<p>On May 13th, 2011, 7:30 a.m., Hugo Pereira Da Costa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for K3b.</div>
<div>By Hugo Pereira Da Costa.</div>
<p style="color: grey;"><i>Updated May 13, 2011, 7:30 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch fixes margins inside themed headers in order to improve the rendering of their inside colored part. See screenshot.
Note: right now, with oxygen from trunk, the rendering of the dialog attached is exactly identical.
This is because a (similar) patch has been added inside oxygen. Now, since its somewhat of a hack, (depending notably on the name of the non-public class for which the layout is to be altered), I'd rather get rid of it and have *this* patch pushed instead.
Besides, this patch also improves the rendering for other widget styles (though not as well as with oxygen).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">tested with oxygen, plastique and skulpture.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/k3bthemedheader.cpp <span style="color: grey">(f5eec73)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101350/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/101350/s/167/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/05/13/k3b_400x100.png" style="border: 1px black solid;" alt="K3B themed header" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>