[k3b] [Bug 381368] "do not show again" from system configuration problems dialog is not remembered

[Wolfgang Bauer]

https://bugs.kde.org/show_bug.cgi?id=381368

Wolfgang Bauer <wbauer at tmo.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wbauer at tmo.at

--- Comment #10 from Wolfgang Bauer <wbauer at tmo.at> ---
(In reply to Leslie Zhai from comment #9)
> The patch had been reviewed by Harald Sitter
> https://twitter.com/apachelogger and I can not reproduce it!

The patch works fine AFAICT, the setting is saved correctly now.

But it is not respected it seems.
FWICT, this is the culprit:
    connect( k3bcore->deviceManager(), SIGNAL(changed()), this,
SLOT(slotCheckSystemTimed()) );
(src/k3b.cpp, line 261)

This causes K3b::SystemProblemDialog::checkSystem() being called *without*
checking the "do not show again" setting.

Removing that line fixes it, but I don't know whether this is a good idea as I
don't know why it is there in the first place.

Maybe it would be better to change K3b::MainWindow::slotCheckSystem() to check
the setting like it is done in K3b::Application::checkSystemConfig().
But to me it seems that both are called on startup currently, which doesn't
really make sense either.

Btw, AFAICS this problem has been introduced in master (but not 2.0.x) years
ago already, long before the port to KF5 started.

-- 
You are receiving this mail because:
You are the assignee for the bug.