<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128868/">https://git.reviewboard.kde.org/r/128868/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks for the patch, we just reverted it a while ago.</p></pre>
<br />
<p>- Albert Astals Cid</p>
<br />
<p>On September 10th, 2016, 2:21 p.m. UTC, Johan Ouwerkerk wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Gwenview, Frederik Gladhorn and Ivan Čukić.</div>
<div>By Johan Ouwerkerk.</div>
<p style="color: grey;"><i>Updated Sept. 10, 2016, 2:21 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
gwenview
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The qAsConst() macro is not available in Qt prior to 5.7, so manually use a const-ref to the container to get the desired behaviour.
(The goal is to avoid detaching of the container).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Note that if the use of if-defs is considered too ugly, there are the following alternatives:
- Revert to using Q_FOREACH() as is done right below the ranged-for loop in the same function anyway
- Use the manual const-ref version and drop the qAsConst() variant entirely.
- If the container is only ever accessed from the same thread, ignore the issue and don't bother with the const-ref (because then there shouldn't be any detaching anyway in this code).
- Bump the required Qt version to >= 5.7</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Built with kdesrc-build against Qt 5.6.x on Debian (Unstable/Sid).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lib/mimetypeutils.cpp <span style="color: grey">(580f9426daa64a7ecda6fccd28fc1ec2d6d51eca)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128868/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>