<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129004/">https://git.reviewboard.kde.org/r/129004/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">alternative patch at
https://git.reviewboard.kde.org/r/129072/</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this patch screenshot:
http://weegie.edinburghlinux.co.uk/~jr/tmp/gwenview-packagekit.png</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">appstream url screenshot:
http://weegie.edinburghlinux.co.uk/~jr/tmp/gwenview-discover.png</p></pre>
<br />
<p>- Jonathan Riddell</p>
<br />
<p>On September 26th, 2016, 4:49 p.m. UTC, Jonathan Riddell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Gwenview and Aleix Pol Gonzalez.</div>
<div>By Jonathan Riddell.</div>
<p style="color: grey;"><i>Updated Sept. 26, 2016, 4:49 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
gwenview
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Use Appstream and Packagekit to offer to install Kipi plugins if they are not already installed</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">compile without appstream/packagekit, works same as before
compile with them it adds a menu entry to install it. This pops up a progressdialog while packagekit installs it. on install the menu gets reloaded with new plugins
(note this doesn't work on neon currently because libkipi-data installs the dummy test plugins so it considers kipi-plugins to be installed, delete those before trying)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(82b219a)</span></li>
<li>app/CMakeLists.txt <span style="color: grey">(ed77d7c)</span></li>
<li>app/kipiinterface.h <span style="color: grey">(1c06cd4)</span></li>
<li>app/kipiinterface.cpp <span style="color: grey">(04dccb3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129004/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>