<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107946/">http://git.reviewboard.kde.org/r/107946/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 27th, 2012, 3:13 p.m., <b>Felix Rohrbach</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107946/diff/1/?file=101842#file101842line4" style="color: black; font-weight: bold; text-decoration: underline;">player/examples/invaders.gluon/game.gluonmeta</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">4</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> projectFilePath string("/<span class="hl">usr</span>/sh<span class="hl">are</span>/gluon/<span class="hl">gam</span>es/invaders.gluon/game.gluonproject")</pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">4</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> projectFilePath string("/<span class="hl">home</span>/sh<span class="hl">iva/kde/src</span>/gluon/<span class="hl">player/exampl</span>es/invaders.gluon/game.gluonproject")</pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Maybe this should be reverted</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This actually is an issue with the current metadata generation - we should either give the projectFilePath a proper purpose or just discard it. Similar to the icon it is one of the few things that always changes when I do some testing with a project.</pre>
<br />
<p>- Arjen</p>
<br />
<p>On December 27th, 2012, 2:28 p.m., Felix Rohrbach wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Gluon and Ganeshprasad Tumkur Paramashivaiah.</div>
<div>By Felix Rohrbach.</div>
<p style="color: grey;"><i>Updated Dec. 27, 2012, 2:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is gani's summer of code work (branch engine-physicscollisions-gani), adding collusions with the bullet library. I rebased the code and did some simple cleanup (whitespace, .directory-files). Note that you need bullet version 2.80, as 2.81 (at least) is source incompatible.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Only compiling</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>engine/CMakeLists.txt <span style="color: grey">(eb86717)</span></li>
<li>engine/cmake/FindGluonEngine.cmake <span style="color: grey">(cd166d0)</span></li>
<li>engine/components/CMakeLists.txt <span style="color: grey">(527d5c7)</span></li>
<li>engine/components/other/physics/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>engine/components/other/physics/boxcollisioncomponent.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>engine/components/other/physics/boxcollisioncomponent.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>engine/components/other/physics/physicsworld.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>engine/components/other/physics/physicsworld.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>engine/components/other/physics/spherecollisioncomponent.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>engine/components/other/physics/spherecollisioncomponent.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>engine/components/other/spherecollision/spherecollisioncomponent.cpp <span style="color: grey">(ef12869)</span></li>
<li>engine/gluon_engine_export.h <span style="color: grey">(f661f69)</span></li>
<li>player/examples/invaders.gluon/.directory <span style="color: grey">(8b3d81a)</span></li>
<li>player/examples/invaders.gluon/game.gluonmeta <span style="color: grey">(4d463de)</span></li>
<li>player/examples/invaders.gluon/game.gluonproject <span style="color: grey">(3a57a72)</span></li>
<li>player/examples/invaders.gluon/game.ico <span style="color: grey">(1c01be8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107946/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>