<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106712/">http://git.reviewboard.kde.org/r/106712/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 9th, 2012, 7:52 p.m., <b>Laszlo Papp</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I was wondering if it made more sense to use the term "axis-aligned bounding box" (AABB) for the filename and class rather than just "axis-aligned box". The former seems to be more common usage out there.</pre>
</blockquote>
<p>On December 11th, 2012, 3:34 p.m., <b>Arjen Hiemstra</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not really. The class itself is not limited to bounding boxes thus it makes no sense to use that name. Furthermore, the getter is called boundingBox() so explicitly states that it is a bounding box.
It is similar to QRect in that regard. There are methods in QGV that return QRects for their bounding rects, but the QRect class is more general-purpose.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1) Will it be used for anything else than bounding box?
2) Now you say actually, the getter is also a bit unclear as the return value is an axis-aligned box, but the getter name is generic (i.e. not axisAlignedBoundingBox()), so it could be different according to the name, not just axis-aligned. So one is specifying the type of bounding box, but the other does not. Perhaps, it would be more consistent by using as close terms as possible.</pre>
<br />
<p>- Laszlo</p>
<br />
<p>On December 1st, 2012, 3:16 p.m., Felix Rohrbach wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Gluon.</div>
<div>By Felix Rohrbach.</div>
<p style="color: grey;"><i>Updated Dec. 1, 2012, 3:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This adds bounding boxes for GameObjects, based on the patch for Components. I'm not really sure if the rotation works, as I don't have much experience in graphics.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles (x86_64, Qt 4.8.3)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>core/axisalignedbox.h <span style="color: grey">(5d9cab1)</span></li>
<li>core/axisalignedbox.cpp <span style="color: grey">(9e7e3eb)</span></li>
<li>engine/gameobject.h <span style="color: grey">(c042e94)</span></li>
<li>engine/gameobject.cpp <span style="color: grey">(a0d059f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106712/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>